fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2025-12-25 14:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

bus_registry_new: Assert in case of not valid context parameter to avoid potiental crashes (CID 54764).

Browse source 
Because the context parameter is dereferenced several times in related code without a null check,
we need to make sure to have a valid context.

Reported by Coverity: CID 54764: Dereference after null check (FORWARD_NULL)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
This commit is contained in:
Ralf Habacker 2015-04-21 13:16:53 +02:00
parent 907c0b36e9
commit d10ac7c57e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bus/services.c
View file

@ -76,6 +76,7 @@ bus_registry_new (BusContext *context)
{
BusRegistry *registry;
_dbus_assert (context);
registry = dbus_new0 (BusRegistry, 1);
if (registry == NULL)
return NULL;
@ -461,8 +462,7 @@ bus_registry_acquire_service (BusRegistry *registry,
}
if (!bus_apparmor_allows_acquire_service (connection,
(registry->context ?
bus_context_get_type (registry->context) : NULL),
bus_context_get_type (registry->context),
_dbus_string_get_const_data (service_name), error))
goto out;