fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-05-07 06:18:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove redundant close() calls

Browse source 
The dup2() calls immediately afterwards will close the "destination" fd
if necessary.

[commit message added -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
This commit is contained in:
Michel HERMIER 2012-11-09 15:53:46 +00:00 • committed by Simon McVittie
parent 5847982adb
commit b8b3feb986
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
dbus/dbus-sysdeps-unix.c
View file

@ -3300,15 +3300,12 @@ _read_subprocess_line_argv (const char *progpath,
/* set-up stdXXX */
close (result_pipe[READ_END]);
close (errors_pipe[READ_END]);
close (0); /* close stdin */
close (1); /* close stdout */
close (2); /* close stderr */
if (dup2 (fd, 0) == -1)
if (dup2 (fd, 0) == -1) /* setup stdin */
_exit (1);
if (dup2 (result_pipe[WRITE_END], 1) == -1)
if (dup2 (result_pipe[WRITE_END], 1) == -1) /* setup stdout */
_exit (1);
if (dup2 (errors_pipe[WRITE_END], 2) == -1)
if (dup2 (errors_pipe[WRITE_END], 2) == -1) /* setup stderr */
_exit (1);
_dbus_close_all ();