fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-02-18 07:10:26 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix memory leak in _dbus_win_set_error_from_win_error().

Browse source 
There is no need to make a local (leaked) copy of the message,
because dbus_set_error() already makes a copy of its parameters.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92721
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
This commit is contained in:
Ralf Habacker 2015-11-11 15:02:44 +01:00
parent 52e97d76a6
commit b4cb853e91
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
dbus/dbus-sysdeps-win.c
View file

@ -3610,13 +3610,8 @@ _dbus_win_set_error_from_win_error (DBusError *error,
(LPSTR) &msg, 0, NULL);
if (msg)
{
char *msg_copy;
msg_copy = dbus_malloc (strlen (msg));
strcpy (msg_copy, msg);
dbus_set_error (error, "win32.error", "%s", msg);
LocalFree (msg);
dbus_set_error (error, "win32.error", "%s", msg_copy);
}
else
dbus_set_error (error, "win32.error", "Unknown error code %d or FormatMessage failed", code);