From aea8da08d12e2d4b224a8d3cdc8b0dee4b856216 Mon Sep 17 00:00:00 2001 From: Christian Dywan Date: Tue, 20 Jul 2010 11:53:15 +0200 Subject: [PATCH] Take care to free windows_sid in cache_peer_loginfo_string --- bus/connection.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bus/connection.c b/bus/connection.c index 718a4f62..8e7d222a 100644 --- a/bus/connection.c +++ b/bus/connection.c @@ -586,9 +586,12 @@ cache_peer_loginfo_string (BusConnectionData *d, if (dbus_connection_get_windows_user (connection, &windows_sid)) { - if (!_dbus_string_append_printf (&loginfo_buf, "sid=\"%s\" ", windows_sid)) - goto oom; + dbus_bool_t did_append; + did_append = _dbus_string_append_printf (&loginfo_buf, + "sid=\"%s\" ", windows_sid); dbus_free (windows_sid); + if (!did_append) + goto oom; } if (!_dbus_string_steal_data (&loginfo_buf, &(d->cached_loginfo_string)))