From ab01169a2046b8affefb8c984e284a4cd28039d4 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Fri, 15 Jul 2022 12:18:04 +0100 Subject: [PATCH] meson: Build with -fno-common if supported This turns off a poorly-supported feature of older compilers. Even when using an older compiler, we want to behave more strictly. The Autotools build already did this. Signed-off-by: Simon McVittie --- meson.build | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build index 765a5a33..638bbf5f 100644 --- a/meson.build +++ b/meson.build @@ -986,6 +986,11 @@ config.set_quoted('DBUS_EXEEXT', exe_ext) compile_warnings = [] compile_warnings_c = [] +# -fno-common makes the linker more strict: on some systems the linker +# is *always* this strict, so we want to behave like that everywhere. +# We treat this like a warning, since that's basically how we're using it. +compile_warnings += ['-fno-common'] + if cc.get_id() == 'msvc' compile_warnings += [ # once