fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-01-05 13:40:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

test-autolaunch-win: Don't overwrite an error with another error

Browse source 
An unrelated branch failed CI with this assertion failure:

    26: dbus[6768]: error: arguments to dbus_set_error() were incorrect,
    assertion "(error) == NULL || !dbus_error_is_set ((error))" failed in
    file ...\dbus-errors.c line 365.

Looking at the test, this seems to be the most likely candidate for
this bug in error handling, which is masking whatever the real cause
for the failure was (we can't tell from here). If
dbus_connection_send_with_reply_and_block() returns NULL, then it should
already have set the error.

Fixing this bug in the error handling will hopefully give us a better
error message for the actual failure if it happens again.

Signed-off-by: Simon McVittie <smcv@collabora.com>
This commit is contained in:
Simon McVittie 2022-10-11 18:36:00 +01:00 • committed by Ralf Habacker
parent 7cee01fca4
commit a7bbff5baf
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
test/name-test/test-autolaunch-win.c
View file

@ -71,7 +71,6 @@ call_method (DBusConnection *conn,
dbus_message_unref (method);
if (reply == NULL)
{
dbus_set_error (error, DBUS_ERROR_FAILED, "Got no reply");
result = FALSE;
goto out;
}