fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-05-02 10:47:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: Fix reading off the end of an array in test-corrupt

Browse source 
One level of pointer indirection too many when passing the arguments to
dbus_message_append_args().

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=100568
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Reviewed-by: Simon McVittie <smcv@collabora.com>
This commit is contained in:
Philip Withnall 2017-04-05 11:35:27 +01:00 • committed by Simon McVittie
parent d7ff4e5b1e
commit 9e864c2e4b
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
test/corrupt.c
View file

@ -271,7 +271,6 @@ test_byte_order (Fixture *f,
int fd;
char *blob;
const gchar *arg = not_a_dbus_message;
const gchar * const *args = &arg;
int blob_len;
DBusMessage *message;
dbus_bool_t mem;
@ -283,7 +282,7 @@ test_byte_order (Fixture *f,
/* Append 0xFF bytes, so that the length of the body when byte-swapped
* is 0xFF000000, which is invalid */
mem = dbus_message_append_args (message,
DBUS_TYPE_ARRAY, DBUS_TYPE_BYTE, &args, 0xFF,
DBUS_TYPE_ARRAY, DBUS_TYPE_BYTE, &arg, 0xFF,
DBUS_TYPE_INVALID);
g_assert (mem);
mem = dbus_message_marshal (message, &blob, &blob_len);