fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-02-02 08:30:37 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bug 18229 - Change system.conf to correctly deny non-reply sends by default

Browse source 
The previous rule <allow send_requested_reply="true"/> was actually
applied to all messages, even if they weren't a reply.  This meant
that in fact the default DBus policy was effectively allow, rather
than deny as claimed.

This fix ensures that the above rule only applies to actual reply
messages.
Signed-off-by: Colin Walters <walters@verbum.org>
This commit is contained in:
Tomas Hoger 2008-12-04 15:19:13 -05:00 • committed by Colin Walters
parent c5526c18ad
commit 8fad15265f
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
bus/system.conf.in
View file

@ -50,9 +50,19 @@
even if they aren't in here -->
<allow send_destination="org.freedesktop.DBus"/>
<allow receive_sender="org.freedesktop.DBus"/>
<!-- valid replies are always allowed -->
<allow send_requested_reply="true"/>
<!-- allow sending valid replies -->
<allow send_requested_reply="true" send_type="method_return"/>
<allow send_requested_reply="true" send_type="error"/>
<!-- allow receiving valid replies -->
<allow receive_requested_reply="true"/>
<!-- Note: the rule above also allows receiving of all non-reply messages
that are not denied later. See:
https://bugs.freedesktop.org/show_bug.cgi?id=18229
Potentially this will be replaced in the future by the
following two rules:
<allow receive_requested_reply="true" receive_type="method_return"/>
<allow receive_requested_reply="true" receive_type="error"/>
-->
<!-- disallow changing the activation environment of system services -->
<deny send_destination="org.freedesktop.DBus"
send_interface="org.freedesktop.DBus"