fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-05-08 10:18:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

dbus-spawn: correct a comment that falsely claimed thread-safety

Browse source 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=60859
Reviewed-by: Chengwei Yang <chengwei.yang@intel.com>
This commit is contained in:
Simon McVittie 2012-12-03 17:43:31 +00:00
parent 33fcec4a47
commit 8b8bbe4c8b
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
dbus/dbus-spawn.c
View file

@ -810,9 +810,14 @@ handle_watch (DBusWatch *watch,
#define WRITE_END 1
/* Avoids a danger in threaded situations (calling close()
* on a file descriptor twice, and another thread has
* re-opened it since the first close)
/* Avoids a danger in re-entrant situations (calling close()
* on a file descriptor twice, and another module has
* re-opened it since the first close).
*
* This previously claimed to be relevant for threaded situations, but by
* trivial inspection, it is not thread-safe. It doesn't actually
* matter, since this module is only used in the -util variant of the
* library, which is only used in single-threaded situations.
*/
static int
close_and_invalidate (int *fd)