CI: Don't change ownership of source directory

These CI scripts were originally used on Travis-CI, which starts all
builds as an ordinary user that has the ability to become root via `sudo`.
On Gitlab-CI, we don't need that: we start as uid 0, and can do the
whole CI run like that. This also means we get somewhat better test
coverage, because some of our unit tests benefit from being run as uid 0.

The only test coverage we lose by being uid 0 is that
test_pending_fd_timeout() in test/dbus-daemon.c is skipped, because
uid 0 bypasses the limit that's under test there.
This commit is contained in:
Simon McVittie 2023-02-06 13:13:04 +00:00
parent cca6c04637
commit 88dd9d5cc7
2 changed files with 1 additions and 7 deletions

View file

@ -142,8 +142,7 @@ windows amd64 image:
# compilers
- export PATH="/usr/lib/ccache:$PATH"
script:
- chown -R user .
- runuser -u user ./tools/ci-build.sh
- ./tools/ci-build.sh
debian image:
extends:

View file

@ -406,11 +406,6 @@ if [ "$ci_local_packages" = yes ]; then
wget ${mirror}/${filename}
tar -C ${dep_prefix} --strip-components=1 -xvf ${filename}
done
# limit access rights
if [ "$ci_in_docker" = yes ]; then
chown -R user "${dep_prefix}"
fi
;;
esac
fi