fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2025-12-30 02:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

2003-01-30 Havoc Pennington <hp@pobox.com>

Browse source 
* dbus/dbus-server.c (dbus_server_listen): @todo about how we need
	a better way to report errors here. e.g.  "unix address lacks
	path" or something. also "no such file" when the path doesn't
	exist, etc.

	* dbus/dbus-address.c (dbus_address_entries_free): add @todo about
	leaking list nodes
	(dbus_parse_address): add @todo about documenting address format,
	and allowing , and ; to be escaped
This commit is contained in:
Havoc Pennington 2003-01-31 00:56:01 +00:00
parent 487f3c1f91
commit 6fc53eb130
4 changed files with 27 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ChangeLog
View file

@ -1,3 +1,15 @@
2003-01-30 Havoc Pennington <hp@pobox.com>
* dbus/dbus-server.c (dbus_server_listen): @todo about how we need
a better way to report errors here. e.g. "unix address lacks
path" or something. also "no such file" when the path doesn't
exist, etc.
* dbus/dbus-address.c (dbus_address_entries_free): add @todo about
leaking list nodes
(dbus_parse_address): add @todo about documenting address format,
and allowing , and ; to be escaped
2003-01-30 Anders Carlsson <andersca@codefactory.se>
* dbus/Makefile.am:

7
dbus/dbus-address.c
View file

@ -73,6 +73,8 @@ dbus_address_entry_free (DBusAddressEntry *entry)
/**
* Frees a #NULL-terminated array of address entries.
*
* @todo dbus_address_entry_free() seems to leak list nodes
*
* @param entries the array.
*/
void
@ -157,6 +159,11 @@ dbus_address_entry_get_value (DBusAddressEntry *entry,
*
* method:key=value,key=value;method:key=value
*
* @todo document address format in the specification
*
* @todo need to be able to escape ';' and ',' in the
* key values, and the parsing needs to handle that.
*
* @param address the address.
* @param entry return location to an array of entries.
* @param array_len return location for array length.

8
dbus/dbus-server.c
View file

@ -191,6 +191,9 @@ _dbus_server_remove_timeout (DBusServer *server,
* dbus_server_set_watch_functions() should be called
* immediately to render the server fully functional.
*
* @todo error messages on bad address could really be better.
* DBusResultCode is a bit limiting here.
*
* @param address the address of this server.
* @param result location to store rationale for failure.
* @returns a new DBusServer, or #NULL on failure.
@ -235,9 +238,10 @@ dbus_server_listen (const char *address,
server = _dbus_server_debug_new (name, result);
if (server)
break;
break;
}
else goto bad_address;
else
goto bad_address;
}
dbus_address_entries_free (entries);

3
dbus/dbus-transport.c
View file

@ -184,7 +184,8 @@ _dbus_transport_finalize_base (DBusTransport *transport)
* Opens a new transport for the given address. (This opens a
* client-side-of-the-connection transport.)
*
* @todo right now the address is just a Unix domain socket path.
* @todo error messages on bad address could really be better.
* DBusResultCode is a bit limiting here.
*
* @param address the address.
* @param result location to store reason for failure.