fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-02-04 22:20:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

nonce: Don't try to rmdir(NULL) on OOM

Browse source 
If re-initializing the string fails, it will be left in a state
where it has a length of 0 and a NULL buffer. That's valid to
"free", but not valid to pass to rmdir().

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107194
(cherry picked from commit 294e8b0b67)
This commit is contained in:
Simon McVittie 2018-07-12 13:32:10 +01:00
parent 9cf2d308ce
commit 5ccd36cecb
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dbus/dbus-nonce.c
View file

@ -367,7 +367,7 @@ do_noncefile_create (DBusNonceFile *noncefile,
return TRUE;
on_error:
if (use_subdir)
if (use_subdir && _dbus_string_get_length (&noncefile->dir) != 0)
_dbus_delete_directory (&noncefile->dir, NULL);
_dbus_string_free (&noncefile->dir);
_dbus_string_free (&noncefile->path);