mirror of
https://gitlab.freedesktop.org/dbus/dbus.git
synced 2025-12-20 09:10:07 +01:00
Relax review criteria for the review cabal themselves, as discussed on-list
Colin agreed in principle and nobody actually objected, so here we go...
This commit is contained in:
parent
ec48c71f70
commit
4bcffe1e05
1 changed files with 14 additions and 0 deletions
14
HACKING
14
HACKING
|
|
@ -298,6 +298,20 @@ rules are:
|
|||
- if there's a live unresolved controversy about a change,
|
||||
don't commit it while the argument is still raging.
|
||||
|
||||
- at their discretion, members of the reviewer group may also commit
|
||||
branches/patches under these conditions:
|
||||
|
||||
- the branch does not add or change API, ABI or wire-protocol
|
||||
|
||||
- the branch solves a known problem and is covered by the regression tests
|
||||
|
||||
- there are no objections from the rest of the review group within
|
||||
a week of the patches being attached to Bugzilla
|
||||
|
||||
- the committer gets a positive review on Bugzilla from someone they
|
||||
consider qualified to review the change (e.g. a colleague with D-Bus
|
||||
experience; not necessarily a member of the reviewer group)
|
||||
|
||||
- regardless of reviews, to commit a patch:
|
||||
- make check must pass
|
||||
- the test suite must be extended to cover the new code
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue