fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2025-12-20 12:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Relax review criteria for the review cabal themselves, as discussed on-list

Browse source 
Colin agreed in principle and nobody actually objected, so here we go...
This commit is contained in:
Simon McVittie 2011-05-25 16:02:43 +01:00
parent ec48c71f70
commit 4bcffe1e05
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
HACKING
View file

@ -298,6 +298,20 @@ rules are:
- if there's a live unresolved controversy about a change, - if there's a live unresolved controversy about a change,
don't commit it while the argument is still raging. don't commit it while the argument is still raging.
- at their discretion, members of the reviewer group may also commit
branches/patches under these conditions:
- the branch does not add or change API, ABI or wire-protocol
- the branch solves a known problem and is covered by the regression tests
- there are no objections from the rest of the review group within
a week of the patches being attached to Bugzilla
- the committer gets a positive review on Bugzilla from someone they
consider qualified to review the change (e.g. a colleague with D-Bus
experience; not necessarily a member of the reviewer group)
- regardless of reviews, to commit a patch: - regardless of reviews, to commit a patch:
- make check must pass - make check must pass
- the test suite must be extended to cover the new code - the test suite must be extended to cover the new code