From 47fc3ed2a9da3bbeb8b4004c8482ca56f69dcf55 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 25 Oct 2018 16:47:18 +0100 Subject: [PATCH] sysdeps: Return an error for _dbus_command_for_pid on Windows If a function returns boolean for success/error, and returns a DBusError, then it should set the DBusError if and only if it returns FALSE. Signed-off-by: Simon McVittie --- dbus/dbus-sysdeps-util-win.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dbus/dbus-sysdeps-util-win.c b/dbus/dbus-sysdeps-util-win.c index 5aad2a86..fc356908 100644 --- a/dbus/dbus-sysdeps-util-win.c +++ b/dbus/dbus-sysdeps-util-win.c @@ -1399,7 +1399,8 @@ _dbus_command_for_pid (unsigned long pid, int max_len, DBusError *error) { - // FIXME + dbus_set_error (error, DBUS_ERROR_NOT_SUPPORTED, + "_dbus_command_for_pid() not implemented on Windows"); return FALSE; }