From 2148a5a80337108dca2b3eae26a4d3c3511204bd Mon Sep 17 00:00:00 2001 From: Ralf Habacker Date: Mon, 21 Sep 2020 14:36:24 +0200 Subject: [PATCH] cmake: install dbus-daemon-launch-helper on Unix Previously it was built on Unix platforms, but not installed. This would prevent traditional activation on the system bus (on Linux without systemd or non-Linux, or for services without SystemdService), which requires the activation helper. Because the executable is an internal implementation detail of how traditional activation is implemented on Unix, it is not exported to the generated cmake support files. Resolves: dbus#310 --- bus/CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bus/CMakeLists.txt b/bus/CMakeLists.txt index 09503966..a52c1bfb 100644 --- a/bus/CMakeLists.txt +++ b/bus/CMakeLists.txt @@ -148,6 +148,10 @@ if(NOT WIN32) add_executable(dbus-daemon-launch-helper activation-helper.c activation-helper-bin.c ) target_link_libraries(dbus-daemon-launch-helper launch-helper-internal) + install(TARGETS dbus-daemon-launch-helper RUNTIME DESTINATION ${CMAKE_INSTALL_LIBEXECDIR}) + # It is intended not to check here that uid is 0 - see https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/154#note_478876 + install(CODE "message(\"-- Note: Not installing \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBEXECDIR}/dbus-daemon-launch-helper binary setuid!\")") + install(CODE "message(\"-- Note: You'll need to manually set permissions to 'root:${DBUS_USER}' and permissions '4750'\")") endif() if(MSVC)