fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-01-06 16:30:18 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix warning: variable 'ret' set but not used [-Wunused-but-set-variable].

Browse source 
Only set valid child status in case exit code has been gotten from
child process, otherwise signal failure through thread return value.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92721
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
This commit is contained in:
Ralf Habacker 2015-11-02 21:56:32 +01:00
parent 34d0c73f99
commit 04b8a7a772
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
dbus/dbus-spawn-win.c
View file

@ -616,13 +616,16 @@ babysitter (void *parameter)
DWORD status;
PING();
// wait until process finished
WaitForSingleObject (sitter->child_handle, INFINITE);
PING();
ret = GetExitCodeProcess (sitter->child_handle, &status);
sitter->child_status = status;
sitter->have_child_status = TRUE;
if (ret)
{
sitter->child_status = status;
sitter->have_child_status = TRUE;
}
CloseHandle (sitter->child_handle);
sitter->child_handle = NULL;
@ -637,7 +640,7 @@ babysitter (void *parameter)
_dbus_babysitter_unref (sitter);
return 0;
return ret ? 0 : 1;
}
dbus_bool_t