mirror of
https://gitlab.freedesktop.org/cairo/cairo.git
synced 2025-12-20 12:50:10 +01:00
d3c4349730
The issue being that as the on-stack data is being referenced via a zero-copy snapshot outside of the functions scope as the surface is only finished and the source written long after the draw() returns. The correct procedure is that the user must call cairo_surface_finish() prior to any surface becoming inaccessible. In this case, this triggers the snapshot to preserve a copy of the data whilst it is still valid.
78 lines
2.6 KiB
C
78 lines
2.6 KiB
C
/*
|
|
* Copyright © 2004 Red Hat, Inc.
|
|
*
|
|
* Permission to use, copy, modify, distribute, and sell this software
|
|
* and its documentation for any purpose is hereby granted without
|
|
* fee, provided that the above copyright notice appear in all copies
|
|
* and that both that copyright notice and this permission notice
|
|
* appear in supporting documentation, and that the name of
|
|
* Red Hat, Inc. not be used in advertising or publicity pertaining to
|
|
* distribution of the software without specific, written prior
|
|
* permission. Red Hat, Inc. makes no representations about the
|
|
* suitability of this software for any purpose. It is provided "as
|
|
* is" without express or implied warranty.
|
|
*
|
|
* RED HAT, INC. DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS
|
|
* SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
|
|
* FITNESS, IN NO EVENT SHALL RED HAT, INC. BE LIABLE FOR ANY SPECIAL,
|
|
* INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER
|
|
* RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
|
|
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
|
|
* IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*
|
|
* Author: Carl D. Worth <cworth@cworth.org>
|
|
*/
|
|
|
|
/* Bug history
|
|
*
|
|
* 2004-10-25 Carl Worth <cworth@cworth.org>
|
|
*
|
|
* It looks like cairo_show_surface has no effect if it follows a
|
|
* call to cairo_move_to to any coordinate other than 0,0. A little
|
|
* bit of poking around suggests this isn't a regression, (at least
|
|
* not since the last pixman snapshot).
|
|
*
|
|
* 2005-04-02 Carl Worth <cworth@cworth.org>
|
|
*
|
|
* Status: RESOLVED
|
|
*
|
|
* Inside cairo_show_surface the current point was being used as
|
|
* both source and destination offsets. After fixing that to use 0,0
|
|
* as the source offset and the current point as the destination
|
|
* offset, the bug seems to be gone.
|
|
*
|
|
*/
|
|
|
|
#include "cairo-test.h"
|
|
|
|
static cairo_test_status_t
|
|
draw (cairo_t *cr, int width, int height)
|
|
{
|
|
cairo_surface_t *surface;
|
|
uint32_t colors[4] = {
|
|
0xffffffff, 0xffff0000,
|
|
0xff00ff00, 0xff0000ff
|
|
};
|
|
int i;
|
|
|
|
for (i=0; i < 4; i++) {
|
|
surface = cairo_image_surface_create_for_data ((unsigned char *) &colors[i],
|
|
CAIRO_FORMAT_RGB24,
|
|
1, 1, 4);
|
|
cairo_set_source_surface (cr, surface,
|
|
i % 2, i / 2);
|
|
cairo_paint (cr);
|
|
|
|
cairo_surface_finish (surface); /* colors will go out of scope */
|
|
cairo_surface_destroy (surface);
|
|
}
|
|
|
|
return CAIRO_TEST_SUCCESS;
|
|
}
|
|
|
|
CAIRO_TEST (move_to_show_surface,
|
|
"Tests calls to cairo_show_surface after cairo_move_to",
|
|
"transform", /* keywords */
|
|
NULL, /* requirements */
|
|
2, 2,
|
|
NULL, draw)
|