fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-05-07 21:28:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
6843 commits 12 branches 118 tags 121 MiB
Commit graph

6843 commits

This branch
This branch
All branches
Author SHA1 Message Date
Chris Wilson
4ba9ccc6ab [configure.ac.analysis] s/safe/_save/ 
Rename the temporary variable in line with the convention used by the rest
of the build system.
 2008-10-20 23:07:38 +01:00
Chris Wilson
3a45b07af9 [perf] Free images for composite-checker 
Fix memleak of the image surfaces.
 2008-10-20 23:04:03 +01:00
Chris Wilson
86356a9578 [test] Add degenerate-dash to XFAIL. 
PS (ghostscript) interprets the degenerate end-caps quite differently, and
perhaps slightly more rationally... Add this to XFAIL, until we have a
definitive specification on how we should behave.
 2008-10-20 23:04:03 +01:00
Behdad Esfahbod
83d2552e4c Remove CAIRO_BEGIN_DECLS uses that ickle introduced while merging 2008-10-20 17:59:41 -04:00
Chris Wilson
eab37f76b0 [directfb] Return an error surface on create() failure. 
Do not return NULL but an NO_MEMORY error surface if we fail to allocate
the surface during creation.
 2008-10-19 22:12:18 +01:00
Chris Wilson
6a02f53dd1 [directfb] Simplifiy ADD_TRI 
Simplify the ADD_TRI macro to make the code more readable.
 2008-10-19 14:21:15 +01:00
Chris Wilson
aba457fe64 [directfb] Add missing error status 
We jumped to the ERROR path without setting an error status - assume
NO_MEMORY.
 2008-10-19 14:03:24 +01:00
Chris Wilson
610451e4a7 [directfb] Correct fixed-to-double conversion. 
The trapezoid calculations had not been updated after the 16.16->24.8
switch. Use _cairo_fixed_to_double() rather than open-coding.
 2008-10-19 12:45:45 +01:00
Chris Wilson
8e0950ced8 [boilerplate/directfb] Gracefully handle failure to create surface. 
Simply return NULL indicating failure to create the target surface rather
than aborting the test (allowing other targets to be tested).
 2008-10-19 12:32:41 +01:00
Chris Wilson
801df1b87a [directfb] Fix error propagation from surface_create() 
Do not mask fatal errors, but correctly propagate the error status.
 2008-10-19 12:32:30 +01:00
Chris Wilson
476d17fa78 [directfb] Compile fix. 
Fixup compilation after 901f0b.
 2008-10-19 11:35:27 +01:00
Chris Wilson
d72969289d [image] Remove unused variable. 
Cleanup the compiler warning for the unused status after code shuffling.
 2008-10-19 09:47:33 +01:00
Chris Wilson
f2ff794426 [perf] A crude tool to visualise performance changes across a series. 
Generate a cairo-perf-diff graph for a series of commits in order to be
able to identify significant commits. Still very crude, but minimally
functional.
 2008-10-19 09:36:53 +01:00
Chris Wilson
41c8eefc6d [output-stream] Protect against NULL write_func. 
Allow the user to specify a NULL write_func for the output stream so that
a dummy surface can be created, for example, for querying target font
options or font extents.

Currently we do not perform any sanity checks at the user entry point and
will generate a mysterious SEGV during cairo_surface_finish() - which may
not immediately be obvious that it is due to a NULL write_func.
 2008-10-19 09:36:53 +01:00
Chris Wilson
84e4a825ff [output-stream] Accept a NULL filename 
Principally to support creating a dummy vector surface (i.e.
cairo_ps_surface_create (NULL, 1, 1)) that can be used to determine font
extents (or target font options) before opening an output file, but also
because we currently fail to do any sanity checking at the entry point.
 2008-10-19 09:36:53 +01:00
Chris Wilson
52ea38f97b [meta] Acquire scaled_font mutex for glyph_path(). 
The caller of _cairo_scaled_font_glyph_path() is expected to be holding
the scaled_font->mutex.
 2008-10-19 09:36:52 +01:00
Chris Wilson
299ea0580a [user-font] Review locks under error conditions. 
Simplify the error handling by only relinquishing the global
scaled_font_map mutex if we successfully insert the placeholder font. The
result is that on the error path, there are no changes to global state and
thus we can entirely skip the user-font initialisation and
re-registration.
 2008-10-19 09:36:52 +01:00
Chris Wilson
c76a8481f3 [analysis] Check for error surfaces. 
If the target surface is an error surface, ensure that we return the
appropriate error surface. Likewise, avoid writing to error surfaces.
 2008-10-19 09:36:52 +01:00
Chris Wilson
5b28b0b903 [ps] Destroy type3 surface on error. 
After an error, ensure that the local type3 surface is destroyed.
 2008-10-19 09:36:52 +01:00
Chris Wilson
6b17c6da47 [type3] Acquire scaled_font mutex whilst looking up glyphs. 
When looking up the glyph in the shared scaled_font glyph cache, the
caller is required to have taken the scaled_font->mutex.
 2008-10-19 09:36:51 +01:00
Chris Wilson
f56cf93181 [user-font] Check for error objects. 
Check that the user has not passed in an inert error object before any
attempts to write to it and return the default values.
 2008-10-19 09:36:51 +01:00
Chris Wilson
1f9f9d936b [pdf] Acquire scaled_font mutex for show_text_glyphs(). 
We need to be holding the scaled font mutex over a call to draw text
glyphs from within an smask group.
 2008-10-19 09:36:51 +01:00
Chris Wilson
12fb8c9b7c [type1] Acquire scaled_font mutex. 
In order to perform glyph lookups we need to be holding the mutex for the
scaled_font.
 2008-10-19 09:36:51 +01:00
Chris Wilson
ca5f868a73 [scaled-font] Zero font extents for an error surface. 
Do not attempt to read from the error object, but just return zero
extents.
 2008-10-19 09:36:51 +01:00
Chris Wilson
1ddf0b2a5c [surface] Reorder asserts to make no assumptions about error objects. 
If the surface is in error, then we cannot assume anything about the
validity of its contents other than the error status (and reference
count). This is for the cases were the surface is replaced by a nil
surface, and in future where the error surface may be replaced by a tiny
error object.
 2008-10-19 09:36:50 +01:00
Chris Wilson
644e78ca4e [svg] Lock the scaled_font whilst emitting glyphs. 
We need to hold the scaled_font mutex whilst looking upon glyphs so lock
the font whilst iterating over the font subset.
 2008-10-19 09:36:50 +01:00
Chris Wilson
4587e9e4f5 [scaled-font-subsets] Add locking to unscaled font. 
During map_glyph() we are passed a locked scaled_font for which we are
asked to add a glyph from that font into the active subsets for the
surface. This means that we eventually call scaled_glyph_lookup() to load
the glyph. But first, we attempt to find an existing an existing sub_font
for glyph, creating a new sub_font as necessary (possibly using an
entirely different unhinted scaled font). So before accessing the glyph
cache we need to make sure that we are holding the appropriate mutexes.
 2008-10-19 09:36:50 +01:00
Chris Wilson
d3a6651237 [xlib] Set return code after failing to allocate glyph surface. 
Although we checked for an allocation error, we missed propagating the
status to the return error code.
 2008-10-19 09:36:50 +01:00
Chris Wilson
bfc3a72cff [gstate] Propagate error from clip. 
During clip transformation we query the clip extents which can trigger a
fatal error. Check and propagate.
 2008-10-19 09:36:50 +01:00
Chris Wilson
7975cf3f2c [paginated] Free local reference to target on error path. 
On the error path we must destroy the local reference to the target
surface.
 2008-10-19 09:36:50 +01:00
Chris Wilson
4662204a2a [test-paginated] Fix double free of surface along error path. 
The ownership of the surface is transferred to the paginated surface, so
we do not need to destroy it ourselves along the error path.
 2008-10-19 09:36:49 +01:00
Chris Wilson
bf3202fcfd [xlib] Fix double free of Pixmap along error path. 
If the paint fails then we attempt to free the Pixmap ourselves and via
the cairo_surface_destroy (as it also believes that it owns the Pixmap).
 2008-10-19 09:36:49 +01:00
Chris Wilson
901f0b540c Review backend->create_similar() 
Avoid masking fatal errors by enforcing any error to be returned via an
error surface, so that the NULL return only means UNSUPPORTED. A few
backends called their create_similar() directly, without correctly checking
for a potential NULL (for example, the directfb backend was a timebomb,
since it used NULL to indicate out-of-memory).
 2008-10-19 09:36:49 +01:00
Chris Wilson
9529699028 [test/user-font-rescale] Check and propagate errors. 
We need to check the error status on set_user_data() to be sure that the
data has been set and error otherwise.
 2008-10-19 09:36:49 +01:00
Chris Wilson
683de2fea2 [test/user-font[-proxy]] Check for error from set_user_data(). 
Check in case we fail to attach our user_data.
 2008-10-18 09:55:15 +01:00
Chris Wilson
1983929900 [test/bitmap] Leak on error path. 
Free the FcPattern on error.
 2008-10-18 09:55:15 +01:00
Chris Wilson
0409be426c [test/font-matrix-translation] Check for OOM 
First check that querying the extents did not trigger NO_MEMORY.
 2008-10-18 09:55:08 +01:00
Chris Wilson
21360bf674 [test/source-surface-big-scaled-down] Propagate error. 
Propagate error to source.
 2008-10-18 09:55:07 +01:00
Chris Wilson
794160c35b [test/surface-pattern] Propagate error. 
Use cairo_get_target() to propagate error from secondary context.
 2008-10-18 09:55:07 +01:00
Chris Wilson
0f48cce8d9 [test/source-clip-scale] Propagate error. 
Use cairo_get_target() to propagate error from secondary context.
 2008-10-18 09:55:07 +01:00
Chris Wilson
6cdbd132ce [test/source-clip] Propagate error. 
Use cairo_get_target() to propagate error from the secondary context.
 2008-10-18 09:55:07 +01:00
Chris Wilson
f86f233b3e [test/smask] Propagate error. 
Use cairo_get_target() to propagate errors from the secondary context.
 2008-10-18 09:55:07 +01:00
Chris Wilson
4490a6c363 [test/stroke-image] Propagate error 
Use cairo_get_target() to propagate errors from the secondary context.
 2008-10-18 09:55:07 +01:00
Chris Wilson
6e6d7e52a3 [test/mask] Propagate error from secondary context. 
Reset the source every time so that the error is propagate from the
secondary context using cairo_get_target().
 2008-10-18 09:55:07 +01:00
Chris Wilson
a56d4530d6 [test/smask-text] Propagate error. 
Use cairo_get_target() to propagate error from the secondary context.
 2008-10-18 09:55:07 +01:00
Chris Wilson
b1e884cd89 [test/smask-stroke] Propagate error. 
Use cairo_get_target() to propagate the error from the secondary context.
 2008-10-18 09:55:07 +01:00
Chris Wilson
546fbc2c0c [test/smask-paint] Propagate error. 
Use cairo_get_target() to propagate errors from the secondary context.
 2008-10-18 09:55:06 +01:00
Chris Wilson
8bd6913282 [test/smask-mask] Propagate error. 
Use cairo_get_target() to propagate errors from the secondary contexts.
 2008-10-18 09:55:06 +01:00
Chris Wilson
9c0fe6c61e [test/smask-image-mask] Propagate error. 
Use cairo_get_target() to propagate any error status from the secondary
context.
 2008-10-18 09:55:06 +01:00
Chris Wilson
373d6c76b6 [test/smask-fill] Propagate error status. 
Use cairo_get_target() to propagate the error from the secondary context.
 2008-10-18 09:55:06 +01:00