fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-05-05 23:58:25 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[test] Add a note to "Getting the elusive zero failures"

Browse source 
The test suite depends upon many external factors and in order to achieve
a pass, your system must match that upon which the reference images were
generated. Add a note to read test/README in case of failures so that the
casual user is not unduly alarmed by cairo reportedly failing.
This commit is contained in:
Chris Wilson 2009-05-09 19:01:06 +01:00
parent 2f962799a7
commit fe7410c6cd
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
test/cairo-test-runner.c
View file

@ -64,6 +64,7 @@ typedef struct _cairo_test_runner {
unsigned int num_device_offsets; unsigned int num_device_offsets;
cairo_bool_t passed;
int num_passed; int num_passed;
int num_xpassed; int num_xpassed;
int num_skipped; int num_skipped;
@ -339,6 +340,8 @@ _runner_init (cairo_test_runner_t *runner)
{ {
cairo_test_init (&runner->base, "cairo-test-suite"); cairo_test_init (&runner->base, "cairo-test-suite");
runner->passed = TRUE;
runner->xpasses_per_target = xcalloc (sizeof (cairo_test_list_t *), runner->xpasses_per_target = xcalloc (sizeof (cairo_test_list_t *),
runner->base.num_targets); runner->base.num_targets);
runner->fails_per_target = xcalloc (sizeof (cairo_test_list_t *), runner->fails_per_target = xcalloc (sizeof (cairo_test_list_t *),
@ -449,6 +452,13 @@ _runner_print_results (cairo_test_runner_t *runner)
{ {
_runner_print_summary (runner); _runner_print_summary (runner);
_runner_print_details (runner); _runner_print_details (runner);
if (! runner->passed) {
_log (&runner->base,
"\n"
"Note: These failures may be due to external factors.\n"
"Please read test/README -- \"Getting the elusive zero failures\".\n");
}
} }
static cairo_test_status_t static cairo_test_status_t
@ -856,6 +866,7 @@ main (int argc, char **argv)
targets[len-2] = '\0'; targets[len-2] = '\0';
_log (&runner.base, "\n%s: CRASH! (%s)\n", name, targets); _log (&runner.base, "\n%s: CRASH! (%s)\n", name, targets);
runner.num_crashed++; runner.num_crashed++;
runner.passed = FALSE;
} else if (failed) { } else if (failed) {
if (expectation == CAIRO_TEST_SUCCESS) { if (expectation == CAIRO_TEST_SUCCESS) {
len = 0; len = 0;
@ -878,6 +889,7 @@ main (int argc, char **argv)
targets[len-2] = '\0'; targets[len-2] = '\0';
_log (&runner.base, "%s: FAIL (%s)\n", name, targets); _log (&runner.base, "%s: FAIL (%s)\n", name, targets);
runner.num_failed++; runner.num_failed++;
runner.passed = FALSE;
} }
} else { } else {
_log (&runner.base, "%s: XFAIL\n", name); _log (&runner.base, "%s: XFAIL\n", name);