fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-02-16 06:10:31 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

cairo-perf-diff: Use median not minimum to report differences

Browse source 
Ideally, the minimum value would indicate the best possible performance,
but I've encountered situations where a bogus minimum value gets lodged
into the cached results for some reason, (and yet doesn't also get
discarded as an outlier). The downside of that situation is that running
more iterations never changes the result, so it's hard to fix the problem,
(resulting in cairo-perf-diff feeling just plain broken as more runs
change nothing).

So let's try using the median time instead.
This commit is contained in:
Carl Worth 2007-04-13 13:34:20 -07:00
parent 7ead3e64f1
commit ef3e13337e
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
perf/cairo-perf-diff-files.c
View file

@ -536,11 +536,11 @@ cairo_perf_report_diff (cairo_perf_report_t *old,
diffs[num_diffs].new = n;
if (args->use_ms) {
diffs[num_diffs].speedup =
(double) (o->stats.min_ticks / o->stats.ticks_per_ms)
/ (n->stats.min_ticks / n->stats.ticks_per_ms);
(double) (o->stats.median_ticks / o->stats.ticks_per_ms)
/ (n->stats.median_ticks / n->stats.ticks_per_ms);
} else {
diffs[num_diffs].speedup =
(double) o->stats.min_ticks / n->stats.min_ticks;
(double) o->stats.median_ticks / n->stats.median_ticks;
}
num_diffs++;
@ -591,9 +591,9 @@ cairo_perf_report_diff (cairo_perf_report_t *old,
printf ("%5s-%-4s %26s-%-3d %6.2f %4.2f%% -> %6.2f %4.2f%%: %5.2fx ",
diff->old->backend, diff->old->content,
diff->old->name, diff->old->size,
diff->old->stats.min_ticks / diff->old->stats.ticks_per_ms,
diff->old->stats.median_ticks / diff->old->stats.ticks_per_ms,
diff->old->stats.std_dev * 100,
diff->new->stats.min_ticks / diff->new->stats.ticks_per_ms,
diff->new->stats.median_ticks / diff->new->stats.ticks_per_ms,
diff->new->stats.std_dev * 100,
change);