fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-05-05 06:28:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[pdiff] Avoid the memleak for small surfaces.

Browse source 
Allocate the arrays after the guard against small surfaces to avoid
leaking them.
This commit is contained in:
Chris Wilson 2007-12-17 22:37:31 +00:00
parent df938a515b
commit ed3fccec01
1 changed files with 26 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
test/pdiff/pdiff.c
View file

@ -257,19 +257,19 @@ pdiff_compare (cairo_surface_t *surface_a,
unsigned int i;
/* assuming colorspaces are in Adobe RGB (1998) convert to XYZ */
float *aX = xmalloc (dim * sizeof (float));
float *aY = xmalloc (dim * sizeof (float));
float *aZ = xmalloc (dim * sizeof (float));
float *bX = xmalloc (dim * sizeof (float));
float *bY = xmalloc (dim * sizeof (float));
float *bZ = xmalloc (dim * sizeof (float));
float *aLum = xmalloc (dim * sizeof (float));
float *bLum = xmalloc (dim * sizeof (float));
float *aX;
float *aY;
float *aZ;
float *bX;
float *bY;
float *bZ;
float *aLum;
float *bLum;
float *aA = xmalloc (dim * sizeof (float));
float *bA = xmalloc (dim * sizeof (float));
float *aB = xmalloc (dim * sizeof (float));
float *bB = xmalloc (dim * sizeof (float));
float *aA;
float *bA;
float *aB;
float *bB;
unsigned int x, y, w, h;
@ -289,6 +289,20 @@ pdiff_compare (cairo_surface_t *surface_a,
if (w < 3 || h < 3) /* too small for the Laplacian convolution */
return -1;
aX = xmalloc (dim * sizeof (float));
aY = xmalloc (dim * sizeof (float));
aZ = xmalloc (dim * sizeof (float));
bX = xmalloc (dim * sizeof (float));
bY = xmalloc (dim * sizeof (float));
bZ = xmalloc (dim * sizeof (float));
aLum = xmalloc (dim * sizeof (float));
bLum = xmalloc (dim * sizeof (float));
aA = xmalloc (dim * sizeof (float));
bA = xmalloc (dim * sizeof (float));
aB = xmalloc (dim * sizeof (float));
bB = xmalloc (dim * sizeof (float));
for (y = 0; y < h; y++) {
for (x = 0; x < w; x++) {
float r, g, b, l;