From d3db983ab2c66e9a53ecbd53f04f56d0723cd3ee Mon Sep 17 00:00:00 2001
From: Carl Worth <cworth@cworth.org>
Date: Tue, 16 Sep 2003 10:28:46 +0000
Subject: [PATCH] Fixed massive pixmap leak

---
 ChangeLog           | 3 +++
 src/cairo-surface.c | 4 ----
 src/cairo_surface.c | 4 ----
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index bb8b389dd..91de45e80 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2003-09-16  Carl Worth  <cworth@isi.edu>
 
+	* src/cairo_surface.c (cairo_surface_create_similar_solid): Fixed
+	massive pixmap leak, (at least one pixmap for every set_rgb_color)
+
 	* configure.in (CAIRO_VERSION): Bumped to 0.1.3 for new functions:
 	cairo_reference and cairo_surface_reference.
 
diff --git a/src/cairo-surface.c b/src/cairo-surface.c
index 472ffa744..c66fef430 100644
--- a/src/cairo-surface.c
+++ b/src/cairo-surface.c
@@ -276,11 +276,7 @@ cairo_surface_create_similar_solid (cairo_surface_t	*other,
 						     NULL,
 						     format,
 						     DefaultColormap (dpy, scr));
-/* XXX: huh? This should be fine since we already created a picture
-	from the pixmap, right?? (Somehow, it seems to be causing some
-	breakage).
 	XFreePixmap (surface->dpy, pix);
-*/
     } else {
 	char *data;
 	int stride;
diff --git a/src/cairo_surface.c b/src/cairo_surface.c
index 472ffa744..c66fef430 100644
--- a/src/cairo_surface.c
+++ b/src/cairo_surface.c
@@ -276,11 +276,7 @@ cairo_surface_create_similar_solid (cairo_surface_t	*other,
 						     NULL,
 						     format,
 						     DefaultColormap (dpy, scr));
-/* XXX: huh? This should be fine since we already created a picture
-	from the pixmap, right?? (Somehow, it seems to be causing some
-	breakage).
 	XFreePixmap (surface->dpy, pix);
-*/
     } else {
 	char *data;
 	int stride;