From 70ca0040fda77b6865c20c94c1b7deaa6e63c481 Mon Sep 17 00:00:00 2001 From: Andrea Canciani Date: Wed, 7 Apr 2010 22:54:57 +0200 Subject: [PATCH] Actually check for memory allocation failure Clang static analyzer signals "Dereference of null pointer" in case the malloc returns NULL, as the code is checking the wrong pointer. --- src/cairo-boxes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cairo-boxes.c b/src/cairo-boxes.c index d2b9e7ec0..363f8e76c 100644 --- a/src/cairo-boxes.c +++ b/src/cairo-boxes.c @@ -128,7 +128,7 @@ _cairo_boxes_add_internal (cairo_boxes_t *boxes, sizeof (cairo_box_t), sizeof (struct _cairo_boxes_chunk)); - if (unlikely (chunk == NULL)) { + if (unlikely (chunk->next == NULL)) { boxes->status = _cairo_error (CAIRO_STATUS_NO_MEMORY); return; }