fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-05-14 10:58:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

DWrite/GeometryRecorder: Add noexcept specifier

Browse source 
STDMETHOD / IFACEMETHOD macros already add __declspec(nothrow), but
noexcept is better. From MSDN [1]:

  We recommend that all new code use the noexcept operator rather than
  __declspec(nothrow).
  This attribute tells the compiler that the declared function and the
  functions it calls never throw an exception. However, it does not
  enforce the directive. In other words, it never causes std::terminate
  to be invoked, unlike noexcept, or in std:c++17 mode (Visual Studio
  2017 version 15.5 and later), throw().

See also [2]:

  Non-throwing functions are permitted to call potentially-throwing
  functions. Whenever an exception is thrown and the search for a handler
  encounters the outermost block of a non-throwing function, the function
  std::terminate is called:

  extern void f(); // potentially-throwing

  void g() noexcept {
    f();      // valid, even if f throws
    throw 42; // valid, effectively a call to std::terminate
  }

References:

 [1] https://learn.microsoft.com/en-us/cpp/cpp/nothrow-cpp?view=msvc-170
 [2] https://en.cppreference.com/w/cpp/language/noexcept_spec
This commit is contained in:
Luca Bacci 2025-01-16 11:52:52 +01:00
parent 8107086c6a
commit 59197e7791
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/win32/cairo-dwrite-font.cpp
View file

@ -846,7 +846,7 @@ public:
, mMatrix(matrix) {}
// IUnknown interface
IFACEMETHOD (QueryInterface)(IID const& iid, OUT void** ppObject) override
IFACEMETHOD (QueryInterface)(IID const& iid, OUT void** ppObject) noexcept override
{
if (iid != __uuidof(IDWriteGeometrySink))
return E_NOINTERFACE;
@ -856,34 +856,34 @@ public:
return S_OK;
}
IFACEMETHOD_(ULONG, AddRef)() override
IFACEMETHOD_(ULONG, AddRef)() noexcept override
{
return 1;
}
IFACEMETHOD_(ULONG, Release)() override
IFACEMETHOD_(ULONG, Release)() noexcept override
{
return 1;
}
IFACEMETHOD_(void, SetFillMode)(D2D1_FILL_MODE fillMode) override
IFACEMETHOD_(void, SetFillMode)(D2D1_FILL_MODE fillMode) noexcept override
{
return;
}
IFACEMETHOD (Close)() override
IFACEMETHOD (Close)() noexcept override
{
return S_OK;
}
IFACEMETHOD_(void, SetSegmentFlags)(D2D1_PATH_SEGMENT vertexFlags) override
IFACEMETHOD_(void, SetSegmentFlags)(D2D1_PATH_SEGMENT vertexFlags) noexcept override
{
return;
}
IFACEMETHOD_(void, BeginFigure)(
D2D1_POINT_2F startPoint,
D2D1_FIGURE_BEGIN figureBegin) override
D2D1_FIGURE_BEGIN figureBegin) noexcept override
{
double x = startPoint.x;
double y = startPoint.y;
@ -897,7 +897,7 @@ public:
}
IFACEMETHOD_(void, EndFigure)(
D2D1_FIGURE_END figureEnd) override
D2D1_FIGURE_END figureEnd) noexcept override
{
if (figureEnd == D2D1_FIGURE_END_CLOSED) {
cairo_status_t status = _cairo_path_fixed_line_to(mCairoPath,
@ -909,7 +909,7 @@ public:
IFACEMETHOD_(void, AddBeziers)(
const D2D1_BEZIER_SEGMENT *beziers,
UINT beziersCount) override
UINT beziersCount) noexcept override
{
for (unsigned int i = 0; i < beziersCount; i++) {
double x1 = beziers[i].point1.x;
@ -934,7 +934,7 @@ public:
IFACEMETHOD_(void, AddLines)(
const D2D1_POINT_2F *points,
UINT pointsCount) override
UINT pointsCount) noexcept override
{
for (unsigned int i = 0; i < pointsCount; i++) {
double x = points[i].x;