fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-02-15 10:20:28 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

[cairo-scaled-font] Destroy the mask on the error path.

Browse source 
Do not leak the mask if we encounter an error whilst tracing.
This commit is contained in:
Chris Wilson 2007-10-04 15:46:13 +01:00
parent d0b1308cd7
commit 4b81eeb20e
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/cairo-scaled-font.c
View file

@ -1381,12 +1381,15 @@ _trace_mask_to_path (cairo_image_surface_t *mask,
double xoff, yoff;
if (mask->format == CAIRO_FORMAT_A1)
a1_mask = mask;
a1_mask = (cairo_image_surface_t *) cairo_surface_reference (&mask->base);
else
a1_mask = _cairo_image_surface_clone (mask, CAIRO_FORMAT_A1);
if (cairo_surface_status (&a1_mask->base))
return cairo_surface_status (&a1_mask->base);
status = cairo_surface_status (&a1_mask->base);
if (status) {
cairo_surface_destroy (&a1_mask->base);
return status;
}
cairo_surface_get_device_offset (&mask->base, &xoff, &yoff);
@ -1399,16 +1402,16 @@ _trace_mask_to_path (cairo_image_surface_t *mask,
status = _add_unit_rectangle_to_path (path,
x - xoff, y - yoff);
if (status)
return status;
goto BAIL;
}
}
}
}
if (a1_mask != mask)
cairo_surface_destroy (&a1_mask->base);
BAIL:
cairo_surface_destroy (&a1_mask->base);
return CAIRO_STATUS_SUCCESS;
return status;
}
cairo_status_t