fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-02-03 10:10:34 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

[test/xlib-surface-source] Fix ill-timed XCloseDisplay

Browse source 
Sigh - finding a crasher in xlib seemed too good to be true. And it was.
The bug is due to the coupling of the XCloseDisplay with the user_data on
the source surface.

This was an externally trigger XCloseDisplay whilst the user had live
surfaces, so I consider this a gross application bug and therefore does
not require graceful handling within cairo-xlib. However, I'm willing to
listen to reason...
This commit is contained in:
Chris Wilson 2008-09-29 15:28:28 +01:00
parent 63ee963c63
commit 41c66a9dfa
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/surface-source.c
View file

@ -101,7 +101,6 @@ draw (cairo_t *cr, int width, int height)
cairo_set_source_surface (cr2, surface,
(INTER_SIZE - SOURCE_SIZE)/2,
(INTER_SIZE - SOURCE_SIZE)/2);
cairo_surface_destroy (surface);
cairo_paint (cr2);
/* and then paint onto a small surface for checking */
@ -112,6 +111,9 @@ draw (cairo_t *cr, int width, int height)
cairo_rectangle (cr, 15, 15, 60, 60);
cairo_fill (cr);
/* destroy the surface last, as this triggers XCloseDisplay */
cairo_surface_destroy (surface);
return CAIRO_TEST_SUCCESS;
}