Change Carl's comment about saturate operator

This commit is contained in:
David Reveman 2005-09-14 09:25:07 +00:00
parent 6121df6b72
commit 34c6f5de9b
2 changed files with 8 additions and 6 deletions

View file

@ -2,6 +2,7 @@
* src/cairo-glitz-surface.c: Track changes to glitz.
Update glyph caching.
(_glitz_operator): Change Carl's comment about saturate operator.
2005-09-13 Carl Worth <cworth@cworth.org>

View file

@ -436,12 +436,13 @@ _glitz_operator (cairo_operator_t op)
case CAIRO_OPERATOR_ADD:
return GLITZ_OPERATOR_ADD;
case CAIRO_OPERATOR_SATURATE:
/* XXX: OVER is definitely not the right thing here, (but it
* is what the original glitz backend code has always
* done). Cairo's SATURATE operator is the native GL
* compositing mode, (from my understanding). So why isn't
* there a GLITZ_OPERATOR_SATURATE for us to use here? */
return GLITZ_OPERATOR_OVER;
/* XXX: This line should never be reached. Glitz backend should bail
out earlier if saturate operator is used. OpenGL can't do saturate
with pre-multiplied colors. Solid colors can still be done as we
can just un-pre-multiply them. However, support for that will have
to be added to glitz. */
/* fall-through */
}
ASSERT_NOT_REACHED;