From b35a9ead9744552ad4e71fe3b12929ab330f8acf Mon Sep 17 00:00:00 2001 From: Uli Schlachter Date: Fri, 31 Jan 2025 18:10:47 +0100 Subject: [PATCH] Fix cairo-fdr and cairo-trace This partially reverts commit ba4d5fbd5 from MR !343 which asked for hidden symbols everywhere. cairo-fdr and cairo-trace explicitly try to interpose existing symbols. Changing them to hidden symbols breaks these tools. See: https://gitlab.freedesktop.org/cairo/cairo/-/issues/882#note_2759005 Signed-off-by: Uli Schlachter --- util/cairo-fdr/meson.build | 1 - util/cairo-trace/meson.build | 1 - 2 files changed, 2 deletions(-) diff --git a/util/cairo-fdr/meson.build b/util/cairo-fdr/meson.build index 0d00e43f7..c333bf765 100644 --- a/util/cairo-fdr/meson.build +++ b/util/cairo-fdr/meson.build @@ -5,7 +5,6 @@ cairo_fdr_sources = [ libcairofdr = library('cairo-fdr', cairo_fdr_sources, include_directories: [incbase, incsrc], dependencies: deps, - gnu_symbol_visibility: 'hidden', link_args: extra_link_args, install: true, install_dir: get_option('libdir') / 'cairo', diff --git a/util/cairo-trace/meson.build b/util/cairo-trace/meson.build index 8d4ac131b..f088c774c 100644 --- a/util/cairo-trace/meson.build +++ b/util/cairo-trace/meson.build @@ -13,7 +13,6 @@ libcairotrace = library('cairo-trace', cairo_trace_sources, dependencies: deps, c_args: ['-DSHARED_LIB_EXT="@0@"'.format(shared_lib_ext),] + pthread_c_args, link_args: extra_link_args, - gnu_symbol_visibility: 'hidden', install: true, install_dir: get_option('libdir') / 'cairo', )