From 2dfee9986c739b2fdadf551dd71e104df332b2b8 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Wed, 6 Aug 2008 10:51:34 +0100 Subject: [PATCH] [pdf] Fixup a couple of inverted tests. Check for NULL returns from malloc, instead of reporting errors and leaking on success. --- src/cairo-pdf-surface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cairo-pdf-surface.c b/src/cairo-pdf-surface.c index 1d1407c95..f58bd7a22 100644 --- a/src/cairo-pdf-surface.c +++ b/src/cairo-pdf-surface.c @@ -4783,8 +4783,8 @@ _cairo_pdf_surface_show_text_glyphs (void *abstract_surface, group->source_res = pattern_res; if (utf8_len) { - group->utf8 = malloc(utf8_len); - if (group->utf8) { + group->utf8 = malloc (utf8_len); + if (group->utf8 == NULL) { _cairo_pdf_smask_group_destroy (group); return _cairo_error (CAIRO_STATUS_NO_MEMORY); } @@ -4804,7 +4804,7 @@ _cairo_pdf_surface_show_text_glyphs (void *abstract_surface, if (num_clusters) { group->clusters = _cairo_malloc_ab (num_clusters, sizeof (cairo_text_cluster_t)); - if (group->clusters) { + if (group->clusters == NULL) { _cairo_pdf_smask_group_destroy (group); return _cairo_error (CAIRO_STATUS_NO_MEMORY); }