fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-04-23 21:30:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: Add cases to exercise clipping after no-ops

Browse source 
Whilst investigating:

  Bug 31788: SVG <line> with y1 == y2 and both with fractional
             part don't render
  https://bugs.webkit.org/show_bug.cgi?id=31788

I found that it can be reduced to a no-op clip following a no-op stroke
or fill. These conditions are exercised here and are shown to be a bug
introduced in the 1.9.x development series.
This commit is contained in:
Benjamin Otte 2009-11-25 10:48:39 +00:00 • committed by Chris Wilson
parent 26e9f14906
commit 0d8a04ef47
6 changed files with 136 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/Makefile.am
View file

@ -175,6 +175,7 @@ REFERENCE_IMAGES = \
clip-fill.ps.xfail.png \
clip-fill.xlib.ref.png \
clip-fill.xlib-fallback.ref.png \
clip-fill-no-op.ref.png \
clip-fill-rule-pixel-aligned.ref.png \
clip-fill-rule-pixel-aligned.rgb24.ref.png \
clip-fill-rule.pdf.argb32.ref.png \
@ -238,6 +239,7 @@ REFERENCE_IMAGES = \
clip-stroke.ref.png \
clip-stroke.xlib.ref.png \
clip-stroke.xlib-fallback.ref.png \
clip-stroke-no-op.ref.png \
clip-stroke-unbounded.argb32.ref.png \
clip-stroke-unbounded.rgb24.ref.png \
clip-stroke-unbounded.svg12.argb32.xfail.png \

2
test/Makefile.sources
View file

@ -18,6 +18,7 @@ test_sources = \
clip-device-offset.c \
clip-empty.c \
clip-fill.c \
clip-fill-no-op.c \
clip-fill-rule.c \
clip-fill-rule-pixel-aligned.c \
clip-fill-unbounded.c \
@ -26,6 +27,7 @@ test_sources = \
clip-operator.c \
clip-push-group.c \
clip-stroke.c \
clip-stroke-no-op.c \
clip-stroke-unbounded.c \
clip-text.c \
clip-twice.c \

66
test/clip-fill-no-op.c Normal file
View file

@ -0,0 +1,66 @@
/*
* Copyright 2009 Benjamin Otte
*
* Permission to use, copy, modify, distribute, and sell this software
* and its documentation for any purpose is hereby granted without
* fee, provided that the above copyright notice appear in all copies
* and that both that copyright notice and this permission notice
* appear in supporting documentation, and that the name of
* Benjamin Otte not be used in advertising or publicity pertaining to
* distribution of the software without specific, written prior
* permission. Benjamin Otte makes no representations about the
* suitability of this software for any purpose. It is provided "as
* is" without express or implied warranty.
*
* BENJAMIN OTTE DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS
* SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
* FITNESS, IN NO EVENT SHALL BENJAMIN OTTE BE LIABLE FOR ANY SPECIAL,
* INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER
* RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
* IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
* Author: Benjamin Otte <otte@gnome.org>
*/
#include "cairo-test.h"
#define WIDTH 50
#define HEIGHT 50
static cairo_test_status_t
draw (cairo_t *cr, int width, int height)
{
/* Neutral gray background */
cairo_set_source_rgb (cr, 0.5, 0.5, 0.5);
cairo_paint (cr);
/* remove this clip operation and everything works */
cairo_rectangle (cr, 10, 10, 30, 30);
cairo_clip (cr);
/* remove this no-op and everything works */
cairo_fill (cr);
/* make the y coordinates integers and everything works */
cairo_move_to (cr, 20, 20.101562);
cairo_line_to (cr, 30, 20.101562);
/* This clip operation should fail to work. But with cairo 1.9, if all the
* 3 cases above happen, the clip will not work and the paint will happen.
*/
cairo_save (cr); {
cairo_set_source_rgba (cr, 1, 0.5, 0.5, 1);
cairo_clip_preserve (cr);
cairo_paint (cr);
} cairo_restore (cr);
return CAIRO_TEST_SUCCESS;
}
CAIRO_TEST (clip_fill_no_op,
"Exercises a bug found by Benjamin Otte whereby a no-op clip is nullified by a stroke",
"clip, fill", /* keywords */
NULL, /* requirements */
WIDTH, HEIGHT,
NULL, draw)

BIN
test/clip-fill-no-op.ref.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 152 B

66
test/clip-stroke-no-op.c Normal file
View file

@ -0,0 +1,66 @@
/*
* Copyright 2009 Benjamin Otte
*
* Permission to use, copy, modify, distribute, and sell this software
* and its documentation for any purpose is hereby granted without
* fee, provided that the above copyright notice appear in all copies
* and that both that copyright notice and this permission notice
* appear in supporting documentation, and that the name of
* Benjamin Otte not be used in advertising or publicity pertaining to
* distribution of the software without specific, written prior
* permission. Benjamin Otte makes no representations about the
* suitability of this software for any purpose. It is provided "as
* is" without express or implied warranty.
*
* BENJAMIN OTTE DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS
* SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
* FITNESS, IN NO EVENT SHALL BENJAMIN OTTE BE LIABLE FOR ANY SPECIAL,
* INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER
* RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
* IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
* Author: Benjamin Otte <otte@gnome.org>
*/
#include "cairo-test.h"
#define WIDTH 50
#define HEIGHT 50
static cairo_test_status_t
draw (cairo_t *cr, int width, int height)
{
/* Neutral gray background */
cairo_set_source_rgb (cr, 0.5, 0.5, 0.5);
cairo_paint (cr);
/* remove this clip operation and everything works */
cairo_rectangle (cr, 10, 10, 30, 30);
cairo_clip (cr);
/* remove this no-op and everything works */
cairo_stroke (cr);
/* make the y coordinates integers and everything works */
cairo_move_to (cr, 20, 20.101562);
cairo_line_to (cr, 30, 20.101562);
/* This clip operation should fail to work. But with cairo 1.9, if all the
* 3 cases above happen, the clip will not work and the paint will happen.
*/
cairo_save (cr); {
cairo_set_source_rgba (cr, 1, 0.5, 0.5, 1);
cairo_clip_preserve (cr);
cairo_paint (cr);
} cairo_restore (cr);
return CAIRO_TEST_SUCCESS;
}
CAIRO_TEST (clip_stroke_no_op,
"Exercises a bug found by Benjamin Otte whereby a no-op clip is nullified by a stroke",
"clip, stroke", /* keywords */
NULL, /* requirements */
WIDTH, HEIGHT,
NULL, draw)

BIN
test/clip-stroke-no-op.ref.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 152 B