fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-23 11:40:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src/dns
History
Thomas Haller ff71bbdc42
Revert "dns: change default DNS priority of VPNs to -50" 
Revert this change. One problem is that none of the current GUIs
(nm-connection-editor, gnome-control-center, plasma-nm) expose the
dns-priority option. So, users tend to have their profile value set to
0. Changing the default means for them not only a change in behavior,
but its hard to fix via the GUI.

Also, what other call DNS leaks, is Split DNS to some. Both uses make
sense, but have conflicting goals. The default cannot accommodate both
at the same time.

Also, with split DNS enabled (dnsmasq, systemd-resolved), the concern
for DNS leaks is smaller. Imagine:

  Wi-Fi profile with ipv4.dns-priority (effectively) 100, domain "example.com".
  VPN profile with ipv4.dns-priority (effectively) 50 and a default route.

That is a common setup that one gets by default (and what probably many
users have today). In such a case with split DNS enabled, the Wi-Fi's DNS
server only sees requests for "*.example.com". So, it does not leak
everything.

Hence, revert this change before 1.28.0 release to the earlier behavior.

This reverts commit af13081bec.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/688
2020-11-23 18:53:52 +01:00
..
nm-dns-dnsmasq.c dns: fix handling default routing domains with systemd-resolved 2020-11-20 18:28:03 +01:00
nm-dns-dnsmasq.h all: unify comment style for SPDX-License-Identifier tag 2020-09-29 16:50:53 +02:00
nm-dns-manager.c dns: fix accessing NULL domains.reverse array in rebuild_domain_lists() 2020-11-20 22:50:31 +01:00
nm-dns-manager.h Revert "dns: change default DNS priority of VPNs to -50" 2020-11-23 18:53:52 +01:00
nm-dns-plugin.c all: unify comment style for SPDX-License-Identifier tag 2020-09-29 16:50:53 +02:00
nm-dns-plugin.h all: unify comment style for SPDX-License-Identifier tag 2020-09-29 16:50:53 +02:00
nm-dns-systemd-resolved.c dns: set first Domains/DefaultRoute in systemd-resolved before DNS 2020-11-20 18:28:48 +01:00
nm-dns-systemd-resolved.h all: unify comment style for SPDX-License-Identifier tag 2020-09-29 16:50:53 +02:00
nm-dns-unbound.c all: unify comment style for SPDX-License-Identifier tag 2020-09-29 16:50:53 +02:00
nm-dns-unbound.h all: unify comment style for SPDX-License-Identifier tag 2020-09-29 16:50:53 +02:00