mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-01-15 02:30:28 +01:00
f8e5e07355
Historically, initscripts' ifup-ib would set the highest bit of PKEY_ID=. That changed and needs to be restored. Note that it probably makes little sense to ever configure p-keys without the highest bit set, because that flag indicates full membership and kernel will automatically add it. At least, kernel will add the flag for the p-key, but not for the automatically chosen interface name. Meaning, writing 0x00f0 to create_child sysctl, results in an interface "$parent.00f0", but `ip -d link` shows pkey 0x80f0. As NetworkManager otherwise supports p-keys without the highest bit set, and since that high bit is honored for the interface name, we cannot just always add the high bit. NetworkManager always assuming the highest bit is set, would change the interface names of existing configuration. With this revert, when a user configures a small p-key and the profile is stored in ifcfg-rh format, the settings backend will automatically mangle the profile and set 0x8000. That is different from when the profile is stored in keyfile format. Since using small p-keys is probably an odd case, we don't try to workaround that any other way (like that ifcfg format could represent the orignal value of the profile and not doing such mangling, or to add the high bit throughout NetworkManager to the p-key). It's an inconsistency, but given the existing behaviors it seems best to stick (revert) to it. This reverts commit |
||
|---|---|---|
| .. | ||
| ifcfg-rh | ||
| ifupdown | ||
| keyfile | ||
| meson.build | ||