Thomas Haller d8a31794c8 connectivity: rework async connectivity check requests ... An asynchronous request should either be cancellable or not keep the target object alive. Preferably both. Otherwise, it is impossible to do a controlled shutdown when terminating NetworkManager. Currently, when NetworkManager is about to terminate, it just quits the mainloop and essentially leaks everything. That is a bug. If we ever want to fix that, every asynchronous request must be cancellable in a controlled way (or it must not prevent objects from getting disposed, where disposing the object automatically cancels the callback). Rework the asynchronous request for connectivity check to - return a handle that can be used to cancel the operation. Cancelling is optional. The caller may choose to ignore the handle because the asynchronous operation does not keep the target object alive. That means, it is still possible to shutdown, by everybody giving up their reference to the target object. In which case the callback will be invoked during dispose() of the target object. - also, the callback will always be invoked exactly once, and never synchronously from within the asynchronous start call. But during cancel(), the callback is invoked synchronously from within cancel(). Note that it's only allowed to cancel an action at most once, and never after the callback is invoked (also not from within the callback itself). - also, NMConnectivity already supports a fake handler, in case connectivity check is disabled via configuration. Hence, reuse the same code paths also when compiling without --enable-concheck. That means, instead of having #if WITH_CONCHECK at various callers, move them into NMConnectivity. The downside is, that if you build without concheck, there is a small overhead compared to before. The upside is, we reuse the same code paths when compiling with or without concheck. - also, the patch synchronizes the connecitivty states. For example, previously `nmcli networking connectivity check` would schedule requests in parallel, and return the accumulated result of the individual requests. However, the global connectivity state of the manager might have have been the same as the answer to the explicit connecitivity check, because while the answer for the manual check is waiting for all pending checks to complete, the global connectivity state could already change. That is just wrong. There are not multiple global connectivity states at the same time, there is just one. A manual connectivity check should have the meaning of ensure that the global state is up to date, but it still should return the global connectivity state -- not the answers for several connectivity checks issued in parallel. This is related to commit b799de281b (libnm: update property in the manager after connectivity check), which tries to address a similar problem client side. Similarly, each device has a connectivity state. While there might be several connectivity checks per device pending, whenever a check completes, it can update the per-device state (and return that device state as result), but the immediate answer of the individual check might not matter. This is especially the case, when a later request returns earlier and obsoletes all earlier requests. In that case, earlier requests return with the result of the currend devices connectivity state. This patch cleans up the internal API and gives a better defined behavior to the user (thus, the simple API which simplifies implementation for the caller). However, the implementation of getting this API right and properly handle cancel and destruction of the target object is more complicated and complex. But this but is not just for the sake of a nicer API. This fixes actual issues explained above. Also, get rid of GAsyncResult to track information about the pending request. Instead, allocate our own handle structure, which ends up to be nicer because it's strongly typed and has exactly the properties that are useful to track the request. Also, it gets rid of the awkward _finish() API by passing the relevant arguments to the callback directly.		2018-04-10 15:11:23 +02:00
..
config	connectivity: rework async connectivity check requests	2018-04-10 15:11:23 +02:00
meson.build	dhcp: remove unused nm_utils_resolve_conf_parse() function	2018-03-20 21:03:20 +01:00
test-dcb.c	all: modify line separator comments to be 80 chars wide	2016-10-03 12:01:15 +02:00
test-general-with-expect.c	tests: use NMTST_EXPECT*() macros	2018-01-08 12:38:54 +01:00
test-general.c	Revert "core: merge branch 'bg/restart-assume-rh1551958'"	2018-04-04 14:49:04 +02:00
test-ip4-config.c	core: use NM_CONSTCAST() for NM_IP_CONFIG_CAST()	2017-11-13 11:35:44 +01:00
test-ip6-config.c	core: distinguish between IFA_F_SECONDARY and IFA_F_TEMPORARY	2018-02-09 21:07:57 +01:00
test-secret-agent.py	python: make test-secret-agent.py python3 ready	2016-12-14 19:00:42 +01:00
test-systemd.c	systemd: merge branch systemd into master	2017-09-21 15:33:32 +02:00
test-utils.c	core: add assertions for network_id/stable_type	2017-01-09 14:50:33 +01:00
test-wired-defname.c	build: don't add subdirectories to include search path but require qualified include	2016-11-21 14:26:37 +01:00