mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2025-12-25 20:00:09 +01:00
f15498eda3
- use svGetValue() instead of svGetValueStr(). The difference is that svGetValueStr() coerces "" to NULL. "" is not a valid value, but we want to parse the value and print an warning message about it. Also, the presence of the variable determines whether we add the bond-port setting or not. - don't use nm_clear_g_free(). @value_to_free is gs_free, it will be cleared automatically. - use g_object_set() instead of nm_g_object_set_property_uint(). The latter is our own implementation that does error checking (e.g., that the value is in range (0..2^16-1). But we already ensured that to be the case. So just call g_object_set(), it cannot fail and if it would, we want the assertion failure that it would cause. - queue_id should be a "guint". It is always true on Linux/glib that sizeof(guint) >= sizeof(guint32), the opposite theoretically might not be true. But later we use the variable in the variadic function g_object_set(), where it should be guint. - the errno from _nm_utils_ascii_str_to_uint64() isn't very useful for logging. It's either ERANGE or EINVAL, and logging the numeric values of these error codes isn't gonna help the user. We could stringify with nm_strerror_native(errno), but that message is also not very useful. Just say that the string is not a number. |
||
|---|---|---|
| .. | ||
| plugins | ||
| nm-agent-manager.c | ||
| nm-agent-manager.h | ||
| nm-secret-agent.c | ||
| nm-secret-agent.h | ||
| nm-settings-connection.c | ||
| nm-settings-connection.h | ||
| nm-settings-plugin.c | ||
| nm-settings-plugin.h | ||
| nm-settings-storage.c | ||
| nm-settings-storage.h | ||
| nm-settings-utils.c | ||
| nm-settings-utils.h | ||
| nm-settings.c | ||
| nm-settings.h | ||