fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-01 13:00:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src
History
Thomas Haller f0442a47ed all: avoid calling g_free on a const pointer with g_clear_pointer() 
With g_clear_pointer(pptr, g_free), pptr is cast to a non-const pointer,
and hence there is no compiler warning about calling g_free() in a const
pointer. However, it still feels ugly to pass a const pointer to
g_clear_pointer(). We should either add an explicity cast, or just
make the pointer non-const.

I guess part of the problem is that C's "const char *" means that the
string itself is immutable, but also that it cannot be freed. We most
often want a different semantic: the string itself is immutable after
being initialized once, but the memory itself can and will be freed.
Such a notion of immutable C strings cannot be expressed.

For that, just remove the "const" from the declarations. Although we
don't want to modify the (content of the) string, it's still more a
mutable string.

Only in _vt_cmd_obj_copy_lnk_vlan(), add an explicity cast but keep the
type as const. The reason is, that we really want that NMPObject
instances are immutable (in the sense that they don't modify while
existing), but that doesn't mean the memory cannot be freed.
2018-03-19 15:45:46 +01:00
..
devices all: avoid calling g_free on a const pointer with g_clear_pointer() 2018-03-19 15:45:46 +01:00
dhcp dhclient: write client-id with backslash and quotes as hex 2018-03-15 17:25:27 +01:00
dns core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
dnsmasq meson: Improve dependency system 2018-01-10 12:20:17 +01:00
ndisc iface-helper: fix non-reentrant call to platform for failed IPv6 DAD 2018-02-21 12:08:46 +01:00
platform all: avoid calling g_free on a const pointer with g_clear_pointer() 2018-03-19 15:45:46 +01:00
ppp core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
settings all: don't explicitly cast destroy function for g_clear_pointer() 2018-03-19 15:27:08 +01:00
supplicant all: don't explicitly cast destroy function for g_clear_pointer() 2018-03-19 15:27:08 +01:00
systemd systemd: merge branch systemd into master 2018-02-23 14:13:43 +01:00
tests core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
vpn core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
main-utils.c all: use nm_close() instead of close() 2017-11-14 15:10:42 +01:00
main-utils.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
main.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
meson.build connectivity: always build nm-connectivity.c source 2018-03-19 14:46:55 +01:00
NetworkManagerUtils.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
NetworkManagerUtils.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-act-request.c all: get rid of a handful of unused-but-set variables 2017-12-18 13:29:32 +01:00
nm-act-request.h core: refactor NMActRequestGetSecretsCallId typedef not to be a pointer to struct 2017-11-24 16:31:29 +01:00
nm-active-connection.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-active-connection.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-audit-manager.c all: don't use NM_FLAGS_HAS() with non-constant argument 2017-12-15 11:48:38 +01:00
nm-audit-manager.h audit: add @args to device logging functions 2017-03-06 10:29:37 +01:00
nm-auth-manager.c logging: log device and connection along with the message 2017-03-24 12:42:09 +01:00
nm-auth-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-auth-subject.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-auth-subject.h auth: embed private data NMAuthSubjectPrivate in NMAuthSubject struct 2016-05-12 10:24:36 +02:00
nm-auth-utils.c all: include "nm-utils/nm-hash-utils.h" by default 2017-11-16 11:49:51 +01:00
nm-auth-utils.h all: move NM_AUTH_PERMISSION_* defines to "nm-common-macros.h" header 2016-06-01 19:06:35 +02:00
nm-checkpoint-manager.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-checkpoint-manager.h core: export checkpoint list over D-Bus 2017-11-09 10:12:15 +01:00
nm-checkpoint.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-checkpoint.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-config-data.c core: extend nm_match_spec_device_by_pllink() with the device-type 2017-12-27 09:42:05 +01:00
nm-config-data.h core: extend nm_match_spec_device_by_pllink() with the device-type 2017-12-27 09:42:05 +01:00
nm-config.c config: fix using the right nm-version for the match specification 2018-01-23 10:50:34 +01:00
nm-config.h core: use define for configuration name "wifi.scan-rand-mac-address" 2017-12-27 09:18:54 +01:00
nm-connectivity.c connectivity: always build nm-connectivity.c source 2018-03-19 14:46:55 +01:00
nm-connectivity.h device: add default route penalty only if concheck is enabled 2017-05-04 11:07:40 +02:00
nm-core-utils.c core: return remaining lifetime from nm_utils_lifetime_get() 2018-02-09 17:40:01 +01:00
nm-core-utils.h core: return remaining lifetime from nm_utils_lifetime_get() 2018-02-09 17:40:01 +01:00
nm-dbus-manager.c dbus: disable all but EXTERNAL D-Bus authentication for private sockets 2018-03-19 11:26:15 +01:00
nm-dbus-manager.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-dbus-object.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-dbus-object.h core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-dbus-utils.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-dbus-utils.h core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-dcb.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-dcb.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nm-dhcp4-config.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-dhcp4-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dhcp6-config.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-dhcp6-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dispatcher.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-dispatcher.h core/dispatcher: pass act-request to device dispatcher calls 2017-03-16 18:27:33 +01:00
nm-firewall-manager.c c-list: re-import latest version of c-list.h from upstream 2017-11-28 11:26:39 +01:00
nm-firewall-manager.h firewall: merge "started" signal and "available" property 2017-04-21 09:09:01 +02:00
nm-hostname-manager.c core,cli: replace wrong pattern for clearing GError 2017-06-27 09:42:28 +02:00
nm-hostname-manager.h hostname: cache hostname-manager's hostname property 2017-05-12 17:29:33 +02:00
nm-iface-helper.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-ip4-config.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-ip4-config.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-ip6-config.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-ip6-config.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-logging.c core/logging: with --debug also output glib messages in stderr 2018-02-07 13:41:52 +01:00
nm-logging.h core: workaround coverity/compiler warning about tautological compare in nm_log_ptr() 2017-10-30 14:41:41 +01:00
nm-manager.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-manager.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-netns.c all: get rid of a handful of unused-but-set variables 2017-12-18 13:29:32 +01:00
nm-netns.h core: rework handling of default-routes and drop NMDefaultRouteManager 2017-09-08 11:11:21 +02:00
nm-pacrunner-manager.c all: get rid of a handful of unused-but-set variables 2017-12-18 13:29:32 +01:00
nm-pacrunner-manager.h proxy: introduce call-id for clearing pacmanager configuration 2017-04-23 18:12:09 +02:00
nm-policy.c core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-policy.h policy: add support to configurable hostname mode 2017-03-24 15:18:09 +01:00
nm-proxy-config.c proxy: reorder parts in nm-proxy-config.c and nm-pacrunner-manager.c 2016-10-04 11:58:32 +02:00
nm-proxy-config.h proxy: remove unnecessary APIs 2016-10-04 11:44:44 +02:00
nm-rfkill-manager.c udev: drop libgudev in favor of libudev 2017-03-22 12:41:06 +01:00
nm-rfkill-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-session-monitor.c session-monitor: fix a -Wcast-function-type warning 2018-03-19 13:05:31 +01:00
nm-session-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-sleep-monitor.c all: use nm_close() instead of close() 2017-11-14 15:10:42 +01:00
nm-sleep-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-test-utils-core.h tests: add NMTST_EXPECT*() macros 2018-01-08 12:38:53 +01:00
nm-types.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
org.freedesktop.NetworkManager.conf dbus: allow firewalld to communicate with NetworkManager 2017-04-21 13:38:21 +02:00