fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-28 01:40:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/contrib
History
Thomas Haller 5e66dcc6ee contrib/checkpatch: avoid command injection in checkpatch.pl script 
The capture variables, $1, etc, are not valid unless the match
succeeded, and they're not cleared, either.

    $ git checkout -B C origin/master && \
        echo XXXXX > f.txt && \
        git add f.txt && \
        git commit -m 'this commit does something()'
    Branch 'C' set up to track remote branch 'master' from 'origin'.
    Reset branch 'C'
    Your branch is up to date with 'origin/master'.
    sh: -c: line 0: syntax error near unexpected token `('
    sh: -c: line 0: `git log --abbrev=12 --pretty=format:"%h ('%s')" -1 does something() 2>/dev/null'

    >>> VALIDATE "a169a98e14 this commit does something()"
    (commit message):4: Commit 'does something()' does not seem to exist:
    > Subject: [PATCH] this commit does something()

    (commit message):4: Refer to the commit id properly: :
    > Subject: [PATCH] this commit does something()

    The patch does not validate.

(cherry picked from commit d66a1ace23)
2019-03-19 16:25:20 +01:00
..
editors contrib: add emacs config for hacking on NM 2015-08-11 13:42:26 -04:00
fedora contrib/rpm: drop ldconfig scriptlets from Fedora 28+ 2019-03-07 22:21:27 +01:00
scripts contrib/checkpatch: avoid command injection in checkpatch.pl script 2019-03-19 16:25:20 +01:00
test all: fix misspellings 2019-01-24 17:19:44 +01:00