mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2025-12-27 18:40:09 +01:00
ea4b4b8775
"debug" is implied when setting NMTST_DEBUG, but not specifying
"no-debug". This change has thus no effect, but it seems clearer to be
explicit.
The "debug" flag affects nmtst_is_debug(). Note that tests *must* not
result in different code paths based on debug, they may only
1) print more debug logging
2) do more assertion checks.
Having more assertion checks can result in different outcome of the
test, that is, that the additional assertion fails first. That is
acceptable, because failing earlier is possibly closer to the issue and
helps debugging. Also, when the additional failure is fixed and passes,
we still will fail at the assertion we are trying to debug.
In particular, an access to nmtst_get_rand*()/nmtst_rand*() must not
depend on nmtst_is_debug(), because then different randomized paths
are taken based on whether debugging is enabled.
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| nm-in-container.d | ||
| btmodem.pl | ||
| checkpatch-feature-branch.sh | ||
| checkpatch-git-post-commit-hook | ||
| checkpatch.pl | ||
| code-style-git-post-commit-hook | ||
| find-backports | ||
| git-subtree-reimport.sh | ||
| modemu.pl | ||
| nm-ci-patch-gtkdoc.sh | ||
| nm-ci-run.sh | ||
| nm-code-format-container.sh | ||
| nm-code-format.sh | ||
| nm-copr-build-nm-git-bundle.sh | ||
| nm-copr-build.sh | ||
| nm-import-openconnect | ||
| nm-import-openvpn | ||
| nm-import-vpnc | ||
| nm-in-container.sh | ||
| NM-log | ||
| nm-python-black-format.sh | ||
| nm-setup-git.sh | ||
| test-create-many-device-setup.sh | ||
| test-macsec | ||
| test-ppp.sh | ||
| test-prefix-delegation.sh | ||