NetworkManager/clients/common
Thomas Haller e95cf643c3 cli: drop invalid validation for default-routes in nmcli
Currently, default-routes cannot be added like regular static-routes
as ipv4.routes setting.
Instead, one has to configure "ipv4.gateway" and "ipv4.never-default".
That of course should be fixed, for example to configure a default-route
in different routing tables.

As it is, both nmcli's parse function and libnm's
NMSettingIPConfig:verify() functions reject default-routes.

But nmcli goes way beyond that, it also rejects all networks with
"0.0.0.0"/"::" even if their prefix length is not zero. Such routes are
not default-routes, and nmcli has no business rejecting them. The
correct way for checking for a default-route is to check the prefix-length
for zero.

Drop the wrong validation in nmcli.

Note, it may still not be the best idea to add catch-all routes like
"0.0.0.0/1" and "128.0.0.0/1". It just defeats what counts as a default-route.
NM has other means (like configuring the route-metric) to handle routing
in face of multiple interfaces. But sure, whatever works for you.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/114
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/75
2019-02-07 17:21:40 +01:00
..
tests build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
meson.build build/meson: add intermediate shared/nm-utils base library 2019-02-05 09:53:24 +01:00
nm-client-utils.c core/devices: Add P2P Wifi device and peer tracking 2019-01-27 23:45:12 +01:00
nm-client-utils.h cli: drop NMCTriStateValue for NMTernary 2018-08-10 10:38:19 +02:00
nm-meta-setting-access.c libnm: use NMMetaSettingInfo for tracking setting priority 2018-08-10 10:38:19 +02:00
nm-meta-setting-access.h cli: remove unused argument from nm_meta_selection_create_parse_list() 2018-07-25 17:08:37 +02:00
nm-meta-setting-desc.c cli: drop invalid validation for default-routes in nmcli 2019-02-07 17:21:40 +01:00
nm-meta-setting-desc.h cli: fix handling uint64 connection property "serial.send-delay" 2018-10-17 16:22:34 +02:00
nm-polkit-listener.c docs: misc. typos 2018-09-15 09:08:03 +02:00
nm-polkit-listener.h docs: misc. typos 2018-09-15 09:08:03 +02:00
nm-secret-agent-simple.c clients/secret-agent: respond to SAE password requests 2019-02-05 10:20:27 +01:00
nm-secret-agent-simple.h clients: don't tread secret agent as NMSecretAgentOld 2019-02-05 08:27:42 +01:00
nm-vpn-helpers.c all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
nm-vpn-helpers.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
settings-docs.h.in libnm-core/setting-wireless-security: add support for SAE key management 2019-02-05 10:20:27 +01:00
settings-docs.xsl cli: fix marking settings docs for translation 2017-04-23 23:45:02 +02:00