mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2025-12-30 12:00:11 +01:00
85d364d765
Due to an error in the loop logic, if there were no connections yet (like a fresh install or a livecd or whatever) no default name would be returned and thus ethernet devices wouldn't come up automatically. Fix that loop error and add testcases for it.
66 lines
1.9 KiB
C
66 lines
1.9 KiB
C
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */
|
|
/* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*
|
|
* (C) Copyright 2011 Red Hat, Inc.
|
|
*/
|
|
|
|
#include <string.h>
|
|
#include <glib.h>
|
|
#include <glib/gi18n.h>
|
|
|
|
#include <nm-connection.h>
|
|
#include "nm-settings-utils.h"
|
|
|
|
char *
|
|
nm_settings_utils_get_default_wired_name (GHashTable *connections)
|
|
{
|
|
GHashTableIter iter;
|
|
NMConnection *connection = NULL;
|
|
GSList *names = NULL, *niter;
|
|
char *cname = NULL;
|
|
int i = 0;
|
|
|
|
/* Build up a list of all existing connection names for dupe checking */
|
|
g_hash_table_iter_init (&iter, connections);
|
|
while (g_hash_table_iter_next (&iter, NULL, (gpointer) &connection)) {
|
|
const char *id;
|
|
|
|
id = nm_connection_get_id (connection);
|
|
g_assert (id);
|
|
names = g_slist_append (names, (gpointer) id);
|
|
}
|
|
|
|
/* Find the next available unique connection name */
|
|
while (!cname && (i++ < 10000)) {
|
|
char *temp;
|
|
gboolean found = FALSE;
|
|
|
|
temp = g_strdup_printf (_("Wired connection %d"), i);
|
|
for (niter = names; niter; niter = g_slist_next (niter)) {
|
|
if (g_strcmp0 (niter->data, temp) == 0) {
|
|
found = TRUE;
|
|
g_free (temp);
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (found == FALSE)
|
|
cname = temp;
|
|
}
|
|
g_slist_free (names);
|
|
|
|
return cname;
|
|
}
|
|
|