mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-27 19:50:08 +01:00

History

Thomas Haller 8e1330964d cli: fix sorting of active connections CMP() is a confusing pattern. Sure enough, the sort order was wrong, for example, `nmcli connection` would show $ nmcli -f STATE,UUID,DEVICE c STATE UUID DEVICE activating 3098c902-c59c-45f4-9e5a-e4cdb79cfe1b nm-bond activated e4fc23ac-54ab-4b1a-932a-ebed12c96d9b eth1 ("activating" shown before "activated"). With `nmcli device`, we sort with compare_devices(). This first sorts by device state (with "connected" being sorted first). Only when the device state is equal, we fallback to nmc_active_connection_cmp(). So with `nmcli device` we usually get "connected" devices first, and we don't really notice that there is a problem with nmc_active_connection_cmp(). On the other hand, `nmcli connection` likes to sort first via nmc_active_connection_cmp(), which gets it wrong. Profiles in "activating" state are sorted first. That's inconsistent with `nmcli device`, but it's also not what is intended. Fix that. Note the change in the test output. Both eth1 and eth0 are connected to to the same profile, but one "eth0" the active-connection's state is DEACTIVATING, while on "eth1" it's ACTIVATED (but both device's states are "CONNECTED"). That's why "eth1" is now sorted first (as desired). Fixes: `a1b25a47b0` ('cli: rework printing of `nmcli connection` for multiple active connections')	2023-11-15 09:34:46 +01:00
..
client	cli: fix sorting of active connections	2023-11-15 09:34:46 +01:00
README.md	all: add some README.md files describing the purpose of our sources	2021-08-19 17:51:11 +02:00

CMP() is a confusing pattern. Sure enough, the sort order was wrong, for
example, `nmcli connection` would show

    $ nmcli -f STATE,UUID,DEVICE c
    STATE       UUID                                  DEVICE
    activating  3098c902-c59c-45f4-9e5a-e4cdb79cfe1b  nm-bond
    activated   e4fc23ac-54ab-4b1a-932a-ebed12c96d9b  eth1

("activating" shown before "activated").

With `nmcli device`, we sort with compare_devices(). This first sorts by
device state (with "connected" being sorted first). Only when the device
state is equal, we fallback to nmc_active_connection_cmp().  So with
`nmcli device` we usually get "connected" devices first, and we don't
really notice that there is a problem with nmc_active_connection_cmp().

On the other hand, `nmcli connection` likes to sort first via
nmc_active_connection_cmp(), which gets it wrong. Profiles in
"activating" state are sorted first. That's inconsistent with `nmcli
device`, but it's also not what is intended.

Fix that.

Note the change in the test output. Both eth1 and eth0 are connected to
to the same profile, but one "eth0" the active-connection's state is
DEACTIVATING, while on "eth1" it's ACTIVATED (but both device's states
are "CONNECTED"). That's why "eth1" is now sorted first (as desired).

Fixes: a1b25a47b0 ('cli: rework printing of `nmcli connection` for multiple active connections')

2023-11-15 09:34:46 +01:00

client cli: fix sorting of active connections 2023-11-15 09:34:46 +01:00

README.md all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00

README.md

tests

Contains some unit tests that don't clearly fit a category to be placed in a different location.

Maybe a better place should be found and this directory should go away.