NetworkManager/src
Thomas Haller db0d84f13a
l3cfg: fix handling "instance-reset" ACD event
The ACD state handling is unfortunately very complicated. That is, because
we obviously need to track state about how ACD is going (the acd_data, and
in particular NML3AcdAddrState). Then there are various things that can
happen, which are the AcdStateChangeMode enums. All these state-changes
come together in one function: _l3_acd_data_state_change(), which is
therefore complicated (I don't think that it would become simpler by
spreading this code out to different functions, on the contrary).
Anyway.

So, what happens when we need to reset the n-acd instance? For example,
because the MAC address of the link changed or some error. I guess, we
need to restart probing.

Previously, I think this was not handled properly. We already tried to
fix this several times, the last was commit b331606386 ('l3cfg: on
n-acd instance-reset clear also ready ACD state'). There is still an
issue ([1]).

The bug [1] is, that we are in state NM_L3_ACD_ADDR_STATE_READY, during
 ACD_STATE_CHANGE_MODE_TIMEOUT event. That leads to an assertion
failure.

  #5  0x00007f23be74698f in g_assertion_message_expr (domain=0x5629aca70359 "nm", file=0x5629aca62aab "src/core/nm-l3cfg.c", line=2395, func=0x5629acb26b30 <__func__.72.lto_priv.4> "_l3_acd_data_state_change", expr=<optimized out>) at ../glib/gtestutils.c:3091
  #6  0x00005629ac937e46 in _l3_acd_data_state_change (self=0x5629add69790, acd_data=0x5629add8d520, state_change_mode=ACD_STATE_CHANGE_MODE_TIMEOUT, sender_addr=0x0, p_now_msec=0x7ffded506460) at src/core/nm-l3cfg.c:2395
  #7  0x00005629ac939f4d in _l3_acd_data_timeout_cb (user_data=user_data@entry=0x5629add8d520) at src/core/nm-l3cfg.c:1933
  #8  0x00007f23be71c5a1 in g_timeout_dispatch (source=0x5629addd7a80, callback=0x5629ac939ee0 <_l3_acd_data_timeout_cb>, user_data=0x5629add8d520) at ../glib/gmain.c:4889
  #9  0x00007f23be71bd4f in g_main_dispatch (context=0x5629adc6da00) at ../glib/gmain.c:3337
  #10 g_main_context_dispatch (context=0x5629adc6da00) at ../glib/gmain.c:4055

That can only happen, (I think) when we scheduled the timeout
during an earlier ACD_STATE_CHANGE_MODE_INSTANCE_RESET event. Meaning,
we need to handle instance-reset better.

Instead, during instance-reset, switch always back to state PROBING, and
let the timeout figure it out.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2047788
2022-02-02 11:08:31 +01:00
..
c-list src/c-list: reimport 2021-10-01 16:18:06 +02:00
c-rbtree c-rbtree: re-import git-subtree for 'src/c-rbtree' 2021-10-01 16:12:15 +02:00
c-siphash c-siphash: re-import git-subtree for 'src/c-siphash' 2021-10-01 16:07:26 +02:00
c-stdaux src/c-stdaux: reimport 2021-10-01 15:57:23 +02:00
contrib format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
core l3cfg: fix handling "instance-reset" ACD event 2022-02-02 11:08:31 +01:00
libnm-base nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00
libnm-client-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-client-impl libnm: use MODEM_CAPS_3GPP()/MODEM_CAPS_3GPP2() macros in get_setting_type() 2022-01-29 16:22:30 +01:00
libnm-client-public format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-client-test format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-aux-intern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-impl libnm: fix bug verifying private-key for WireGuard setting 2022-01-20 22:22:41 +01:00
libnm-core-intern libnm: add and use _nm_setting_get_private_field() helper 2022-01-18 16:25:24 +01:00
libnm-core-public device/wwan: static assert that ModemManager and NM capabilities correspond 2022-01-29 16:26:02 +01:00
libnm-glib-aux glib-aux/tests: add tests for nm_ref_string_equal_str() 2022-01-27 19:04:44 +01:00
libnm-log-core format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-log-null all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
libnm-platform platform: don't put certain rtm_protocol routes in the platform cache 2022-01-20 10:30:34 +01:00
libnm-std-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-systemd-core systemd: byte order to host before using the lifetime 2021-11-30 11:42:40 +01:00
libnm-systemd-shared systemd: merge branch systemd into main 2021-10-08 18:04:37 +02:00
libnm-udev-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-base format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-setting libnm/tests: fix maybe-uninitialized warning in "test-libnmc-setting" 2022-01-20 22:34:01 +01:00
libnmt-newt format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
linux-headers linux-headers: update nl802154.h kernel header 2021-09-06 10:00:36 +02:00
n-acd n-acd: fix handling of N_ACD_E_DROPPED 2021-09-30 15:10:17 +02:00
n-dhcp4 n-dhcp4: add an accessor for the file name in the lease 2021-07-27 09:36:33 +02:00
nm-cloud-setup format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
nm-daemon-helper all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
nm-dispatcher format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
nm-initrd-generator initrd: add support for rd.znet_ifnames 2022-01-25 14:57:22 +01:00
nm-online format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
nm-priv-helper nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00
nmcli openvswitch: Add ovs-dpdk n_rxq property 2022-01-10 22:48:30 +00:00
nmtui format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
tests cli: correct active connection details header in nmcli output 2022-01-03 12:24:46 +01:00
meson.build nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00
README.md nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library