Find a file
Thomas Haller d65ee3bb18 dhcp6: don't enforce DUID content for sd_dhcp6_client_set_duid()
There are various functions to set the DUID of a DHCPv6 client.
However, none of them allows to set arbitrary data. The closest is
sd_dhcp6_client_set_duid(), which would still do validation of the
DUID's content via dhcp_validate_duid_len().

Relax the validation and only log a debug message if the DUID
does not validate.

Note that dhcp_validate_duid_len() already is not very strict. For example
with DUID_TYPE_LLT it only ensures that the length is suitable to contain
hwtype and time. It does not further check that the length of hwaddr is non-zero
or suitable for hwtype. Also, non-well-known DUID types are accepted for
extensibility. Why reject certain DUIDs but allowing clearly wrong formats
otherwise?

The validation and failure should happen earlier, when accepting the
unsuitable DUID. At that point, there is more context of what is wrong,
and a better failure reason (or warning) can be reported to the user. Rejecting
the DUID when setting up the DHCPv6 client seems not optimal, in particular
because the DHCPv6 client does not care about actual content of the
DUID and treats it as opaque blob.

Also, NetworkManager (which uses this code) allows to configure the entire
binary DUID in binary. It intentionally does not validate the binary
content any further. Hence, it needs to be able to set _invalid_ DUIDs,
provided that some basic constraints are satisfied (like the maximum length).

sd_dhcp6_client_set_duid() has two callers: both set the DUID obtained
from link_get_duid(), which comes from configuration.
`man networkd.conf` says: "The configured DHCP DUID should conform to
the specification in RFC 3315, RFC 6355.". It does not not state that
it MUST conform.

Note that dhcp_validate_duid_len() has another caller: DHCPv4's
dhcp_client_set_iaid_duid_internal(). In this case, continue with
strict validation, as the callers are more controlled. Also, there is
already sd_dhcp_client_set_client_id() which can be used to bypass
this check and set arbitrary client identifiers.

ab4a88bc29
2018-12-21 19:29:35 +01:00
clients build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
contrib build: meson: Remove polkit_dir option 2018-12-20 13:50:34 +01:00
data build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
dispatcher build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
docs build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
examples build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
introspection build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
libnm build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
libnm-core build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
libnm-glib build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
libnm-util build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
m4 build: don't change CFLAGS from configure.ac 2018-09-18 15:15:31 +02:00
man build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
po all: say Wi-Fi instead of "wifi" or "WiFi" 2018-11-29 17:53:35 +01:00
shared build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
src dhcp6: don't enforce DUID content for sd_dhcp6_client_set_duid() 2018-12-21 19:29:35 +01:00
tools meson: add check on settings docs 2018-12-12 14:38:18 +01:00
vapi build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
.dir-locals.el misc: add toplevel .dir-locals file that tells Emacs to show trailing whitespace 2013-03-08 15:15:28 +01:00
.gitignore shared/tests: add test for "shared/nm-utils" 2018-10-18 12:16:55 +02:00
.gitlab-ci.yml gitlab-ci: patch gtk-doc to generate valid documentation 2018-12-01 08:55:44 +01:00
.mailmap mailmap: update user 2018-10-01 12:02:55 +02:00
.travis.yml ci: use common script for tests on travis and gitlab 2018-11-12 11:29:37 +01:00
AUTHORS misc: update maintainers and authors 2016-04-21 13:39:03 -05:00
autogen.sh build: disable libnm-glib by default 2018-06-15 13:07:53 +02:00
ChangeLog all: point git references to the GitLab instance 2018-08-27 11:36:56 +02:00
config-extra.h.meson build: move paths of dhcp clients from config-extra.h to config.h 2018-09-13 14:35:15 +02:00
config.h.meson build: add configure check for having memfd_create() API 2018-10-25 16:37:35 +02:00
configure.ac doc,all: fix spelling of Open vSwitch (instead of OpenVSwitch) 2018-11-28 14:26:42 +01:00
CONTRIBUTING Make licensing of contributions more explicit 2017-07-25 07:16:35 +02:00
COPYING docs: create new master NM documentation module 2011-02-16 16:24:16 -06:00
linker-script-binary.ver iface-helper/build: add linker version script 2016-10-13 21:33:33 +02:00
linker-script-devices.ver devices/build: use one linker-script-devices.ver for all device plugins 2016-10-13 21:36:06 +02:00
linker-script-settings.ver settings/build: add linker version script for settings plugins 2016-10-13 21:33:33 +02:00
MAINTAINERS misc: update maintainers and authors 2016-04-21 13:39:03 -05:00
Makefile.am meson: add check on settings docs 2018-12-12 14:38:18 +01:00
Makefile.examples examples/python: drop nmex.py 2018-06-29 20:05:39 +02:00
Makefile.glib build: include "config.h" in nm*enum-types.c sources 2015-10-05 15:01:38 +02:00
Makefile.vapigen build: fix make always re-making vapigen target 2016-10-21 18:46:03 +02:00
meson.build build: meson: Remove unnecessary auxiliary variable 2018-12-20 13:50:34 +01:00
meson_options.txt build: meson: Use variables present in pkg-config files 2018-12-20 13:50:34 +01:00
NetworkManager.pc.in build: update NetworkManager.pc 2013-01-29 16:17:30 -05:00
NEWS all: say Wi-Fi instead of "wifi" or "WiFi" 2018-11-29 17:53:35 +01:00
README readme: update issue tracker address 2018-09-20 10:52:52 +02:00
TODO all: say Wi-Fi instead of "wifi" or "WiFi" 2018-11-29 17:53:35 +01:00
valgrind.suppressions valgrind: update glib2 suppression for Fedora 27 2017-11-15 17:05:01 +01:00
zanata.xml po: add Zanata configuration 2016-04-05 14:35:53 +02:00

******************
2008-12-11: NetworkManager core daemon has moved to git.freedesktop.org!

git clone git://git.freedesktop.org/git/NetworkManager/NetworkManager.git
******************


Networking that Just Works
--------------------------

NetworkManager attempts to keep an active network connection available at all
times.  The point of NetworkManager is to make networking configuration and
setup as painless and automatic as possible.  NetworkManager is intended to
replace default route, replace other routes, set IP addresses, and in general
configure networking as NM sees fit (with the possibility of manual override as
necessary).  In effect, the goal of NetworkManager is to make networking Just
Work with a minimum of user hassle, but still allow customization and a high
level of manual network control.  If you have special needs, we'd like to hear
about them, but understand that NetworkManager is not intended for every
use-case.

NetworkManager will attempt to keep every network device in the system up and
active, as long as the device is available for use (has a cable plugged in,
the killswitch isn't turned on, etc).  Network connections can be set to
'autoconnect', meaning that NetworkManager will make that connection active
whenever it and the hardware is available.

"Settings services" store lists of user- or administrator-defined "connections",
which contain all the settings and parameters required to connect to a specific
network.  NetworkManager will _never_ activate a connection that is not in this
list, or that the user has not directed NetworkManager to connect to.


How it works:

The NetworkManager daemon runs as a privileged service (since it must access
and control hardware), but provides a D-Bus interface on the system bus to
allow for fine-grained control of networking.  NetworkManager does not store
connections or settings, it is only the mechanism by which those connections
are selected and activated.

To store pre-defined network connections, two separate services, the "system
settings service" and the "user settings service" store connection information
and provide these to NetworkManager, also via D-Bus.  Each settings service
can determine how and where it persistently stores the connection information;
for example, the GNOME applet stores its configuration in GConf, and the system
settings service stores its config in distro-specific formats, or in a distro-
agnostic format, depending on user/administrator preference.

A variety of other system services are used by NetworkManager to provide
network functionality: wpa_supplicant for wireless connections and 802.1x
wired connections, pppd for PPP and mobile broadband connections, DHCP clients
for dynamic IP addressing, dnsmasq for proxy nameserver and DHCP server
functionality for internet connection sharing, and avahi-autoipd for IPv4
link-local addresses.  Most communication with these daemons occurs, again,
via D-Bus.


Why doesn't my network Just Work?

Driver problems are the #1 cause of why NetworkManager sometimes fails to
connect to wireless networks.  Often, the driver simply doesn't behave in a
consistent manner, or is just plain buggy.  NetworkManager supports _only_
those drivers that are shipped with the upstream Linux kernel, because only
those drivers can be easily fixed and debugged.  ndiswrapper, vendor binary
drivers, or other out-of-tree drivers may or may not work well with
NetworkManager, precisely because they have not been vetted and improved by the
open-source community, and because problems in these drivers usually cannot
be fixed.

Sometimes, command-line tools like 'iwconfig' will work, but NetworkManager will
fail.  This is again often due to buggy drivers, because these drivers simply
aren't expecting the dynamic requests that NetworkManager and wpa_supplicant
make.  Driver bugs should be filed in the bug tracker of the distribution being
run, since often distributions customize their kernel and drivers.

Sometimes, it really is NetworkManager's fault.  If you think that's
the case, please file a bug at:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues

Attaching NetworkManager debug logs from the journal (or wherever your
distribution directs syslog's 'daemon' facility output, as
/var/log/messages or /var/log/daemon.log) is often very helpful, and
(if you can get) a working wpa_supplicant config file helps
enormously.  See the logging section of file
contrib/fedora/rpm/NetworkManager.conf for how to enable debug logging
in NetworkManager.