fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-03-21 18:00:38 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src
History
Íñigo Huguet 3904135150 wifi: don't recheck auto-activate on disposal 
During disposal we're calling to remove_all_aps that in turns schedules
an auto-activate recheck. As the device is removed, this triggers an
assertion when trying to do the recheck.

Fix that by not scheduling the recheck.

Example of backtrace that this commits fix:
  0  __libc_do_syscall () at ../sysdeps/unix/sysv/linux/arm/libc-do-syscall.S:47
  1  0xf746e270 in __pthread_kill_implementation (threadid=<optimized out>, signo=6, no_tid=<optimized out>) at pthread_kill.c:43
  2  0xf743fbc6 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
  3  0xf7431614 in __GI_abort () at abort.c:79
  4  0xf775afea in g_assertion_message (domain=domain@entry=0x209a9f "nm", file=file@entry=0x1f7d59 "../NetworkManager-1.43.7/src/core/nm-policy.c", line=line@entry=1665,
     func=func@entry=0x1f94d9 <__func__.6> "nm_policy_device_recheck_auto_activate_schedule",
     message=message@entry=0x1d3e950 "assertion failed: (g_signal_handler_find(device, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, NM_POLICY_GET_PRIVATE(self)) != 0)")
     at ../glib-2.72.3/glib/gtestutils.c:3253
  5  0xf775b05e in g_assertion_message_expr (domain=0x209a9f "nm", file=0x1f7d59 "../NetworkManager-1.43.7/src/core/nm-policy.c", line=1665,
     func=0x1f94d9 <__func__.6> "nm_policy_device_recheck_auto_activate_schedule",
     expr=0x1f8afc "g_signal_handler_find(device, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, NM_POLICY_GET_PRIVATE(self)) != 0") at ../glib-2.72.3/glib/gtestutils.c:3279
  6  0x0005f27a in nm_policy_device_recheck_auto_activate_schedule (self=0x1d3e950, device=0x209a9f) at ../NetworkManager-1.43.7/src/core/nm-policy.c:1679
  7  0x000548ae in nm_manager_device_recheck_auto_activate_schedule (self=<optimized out>, device=<optimized out>) at ../NetworkManager-1.43.7/src/core/nm-manager.c:3113
  8  0x00070622 in nm_device_recheck_auto_activate_schedule (self=<optimized out>) at ../NetworkManager-1.43.7/src/core/devices/nm-device.c:9249
  9  0xf693aa8c in ap_add_remove (self=self@entry=0x1ceb0b0, is_adding=0, ap=<optimized out>, recheck_available_connections=0)
     at ../NetworkManager-1.43.7/src/core/devices/wifi/nm-device-wifi.c:846
  10 0xf693bcda in remove_all_aps (self=self@entry=0x1ceb0b0) at ../NetworkManager-1.43.7/src/core/devices/wifi/nm-device-wifi.c:863
  11 0xf693f83c in dispose (object=0x1ceb0b0) at ../NetworkManager-1.43.7/src/core/devices/wifi/nm-device-wifi.c:3809
  12 0xf7806e72 in g_object_unref (_object=<optimized out>) at ../glib-2.72.3/gobject/gobject.c:3636
  13 g_object_unref (_object=0x1ceb0b0) at ../glib-2.72.3/gobject/gobject.c:3553
  14 0x000f7fa4 in _nm_dbus_object_clear_and_unexport (location=location@entry=0xffa50644) at ../NetworkManager-1.43.7/src/core/nm-dbus-object.c:203
  15 0x000576e4 in remove_device (self=self@entry=0x1c9c900, device=<optimized out>, quitting=quitting@entry=1) at ../NetworkManager-1.43.7/src/core/nm-manager.c:2289
  16 0x0005a864 in nm_manager_stop (self=self@entry=0x1c9c900) at ../NetworkManager-1.43.7/src/core/nm-manager.c:7784
  17 0x00023438 in main (argc=<optimized out>, argv=<optimized out>) at ../NetworkManager-1.43.7/src/core/main.c:530

Fixes: 96f40dcdcd ('wifi/ap: explicitly unexport AP and refactor add/remove AP')
Fixes: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1791
2025-08-27 06:37:33 +00:00
..
c-list
c-rbtree
c-siphash
c-stdaux
contrib contrib/nm-vpn-plugin-utils: add nm_vpn_plugin_utils_get_cert_path() 2025-07-09 15:06:51 +02:00
core wifi: don't recheck auto-activate on disposal 2025-08-27 06:37:33 +00:00
libnm-base dns: Add resolve-mode and certification-authority keys to global-dns 2025-01-29 14:41:47 +01:00
libnm-client-aux-extern nmcli: add support for managing wireguard peers 2025-06-16 13:20:02 +02:00
libnm-client-impl libnm: add nm_dns_server_validate() 2025-08-14 11:22:41 +02:00
libnm-client-public libnm, nmcli: introduce new "prefix-delegation" setting 2025-04-02 11:21:59 +02:00
libnm-client-test typo fix: allows to -> allows one to 2025-03-26 19:22:01 +01:00
libnm-core-aux-extern nmcli: add support for managing wireguard peers 2025-06-16 13:20:02 +02:00
libnm-core-aux-intern dns: return error from nm_dns_uri_parse() 2025-08-14 09:40:26 +02:00
libnm-core-impl dns: don't break existing configs with wrong separators in dns-search 2025-08-26 08:59:37 +00:00
libnm-core-intern libnm, nmcli: introduce new "prefix-delegation" setting 2025-04-02 11:21:59 +02:00
libnm-core-public libnm: add nm_dns_server_validate() 2025-08-14 11:22:41 +02:00
libnm-crypto Updated code format 2024-04-08 06:35:20 +00:00
libnm-glib-aux all: code format 2025-05-13 11:43:33 +02:00
libnm-lldp format: run nm-code-format 2024-10-04 11:07:35 +02:00
libnm-log-core all: code format 2025-05-13 11:43:33 +02:00
libnm-log-null
libnm-platform platform: fix GError free function 2025-07-23 11:11:59 +02:00
libnm-std-aux typo fix: allow to -> allow one to 2025-03-26 19:22:56 +01:00
libnm-systemd-core dhcp6: fix accessor macro for t2 2025-07-23 11:00:13 +02:00
libnm-systemd-shared merge: branch 'systemd' into jv/systemd-merge 2025-06-02 10:00:31 +02:00
libnm-udev-aux
libnmc-base libnmc: fix typo of missing close parenthesis 2025-08-25 13:35:33 +00:00
libnmc-setting ipv4: remove the forwarding=ignore value 2025-06-19 12:27:35 +00:00
libnmt-newt nmtui: handle write() errors correctly in nmt_newt_edit_string 2024-06-28 10:58:11 +00:00
linux-headers platform: remove CSME related code 2023-09-25 11:46:24 +00:00
n-acd n-acd: use separate seed state for each probe of the same acd 2023-10-05 09:02:57 +02:00
n-dhcp4 n-dhcp4: fix resource leaks 2025-04-07 14:15:09 +00:00
nm-cloud-setup cloud-setup: configure disconnected wired devices on OCI 2025-04-11 11:44:05 +02:00
nm-compat-headers
nm-daemon-helper nm-daemon-helper: add "service" argument 2024-07-04 15:39:03 +02:00
nm-dispatcher all: code format 2025-05-13 11:43:33 +02:00
nm-initrd-generator nm-initrd-generator: add NBFT parser tests 2025-08-26 07:45:53 +00:00
nm-online all: use NM_MAX() instead of MAX() 2023-11-15 09:32:21 +01:00
nm-priv-helper format: run nm-code-format 2024-10-04 11:07:35 +02:00
nmcli nmcli: fix format 2025-07-09 15:08:15 +02:00
nmtui nmtui/editor: hide "device" field for loopback connections 2025-04-15 11:43:06 +00:00
tests nmcli: accept certain IP settings on port connections 2025-07-01 14:22:42 +02:00
meson.build ip: configurable address pool and lease time of DHCP server in shared mode 2024-12-11 09:20:15 +01:00
README.md

README.md

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library