mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-05-03 06:38:05 +02:00
d1566d7b4b
All usages of nm_settings_connection_clear_secrets() outside of the NMSettingsConnection implementation were setting the clear_cached_system_secrets parameter to FALSE which meant that the operation was a no-op since the system-secrets cache kept a copy of the secrets being cleared and any access to the SettingsConnection through the D-Bus API or the class methods would behave the same as without the call, with the exception of directly reading the settings from the result of nm_settings_connection_get_connection(). The calls would still generate D-Bus and gobject signals however, which were redundant. Drop the method and its calls from the rest of NM code as not needed and potentially confusing. The comments preceding these calls implied that they were needed so that the next activation attempt would be forced to use nm_settings_connection_get_secrets() but this was the case probably only before the applied connection concept was introduced. Also drop two nm_active_connection_clear_secrets() uses in NMVpnConnection, right before the teardown of the active connection, that could only possibly have any effect if they affected the NMSettingsConnection, but as mentioned earlier the nm_settings_connection_clear_secrets() use inside nm_active_connection_clear_secrets() didn't do anything and is now removed. The one internal use of nm_active_connection_clear_secrets() in the D-Bus ClearSecrets() implementation is inlined. |
||
|---|---|---|
| .. | ||
| nm-vpn-connection.c | ||
| nm-vpn-connection.h | ||
| nm-vpn-manager.c | ||
| nm-vpn-manager.h | ||