fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-28 13:20:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src
History
Thomas Haller d008eb154e
device: don't reset "net.ipv6.conf.$IFACE.forwarding" 
According to systemd, IPv6 forwarding is special anyway, and they only
enable forwarding for "net.ipv6.conf.all.forwarding" ([1]).

Since commit 46e63e03af ('device: announce the managed IPv6
configuration with ipv6.method=shared') we support "ipv6.method=shared"
and enable forwarding for IPv6, on the interface. Whether that makes
sense is questionable, given [1] and the claim that setting it
per-interface is not useful.

Anyway, since that change we always reset the "forwarding" sysctl to
zero, when we don't enable shared mode. That is not right, because the
user didn't explicitly ask for that (and there is no configuration
option like systemd-networkd's "IPForward=" setting to control that).

What we instead should do, not touch/reset the sysctl, unless we really
want to.

No longer set "forwarding" to zero by default. And only restore the
previous value (_dev_sysctl_save_ip6_properties()) if we actually
changed the value to "1".

[1] b8fba0cded/src/network/networkd-sysctl.c (L79)

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/923

Fixes: 46e63e03af ('device: announce the managed IPv6 configuration with ipv6.method=shared')

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1616
(cherry picked from commit 4c48301594)
(cherry picked from commit f578051b40)
2023-06-12 10:44:40 +02:00
..
c-list c-list: re-import git-subtree for 'src/c-list' 2022-07-19 09:02:36 +02:00
c-rbtree modules: patch meson subprojects to use local dependencies 2022-07-25 10:27:33 +02:00
c-siphash modules: patch meson subprojects to use local dependencies 2022-07-25 10:27:33 +02:00
c-stdaux c-stdaux: re-import git-subtree for 'src/c-stdaux' 2022-07-25 10:29:09 +02:00
contrib all: adjust glib-mkenums annotations for automated formatting 2022-02-08 11:14:01 +01:00
core device: don't reset "net.ipv6.conf.$IFACE.forwarding" 2023-06-12 10:44:40 +02:00
libnm-base bonding: add support to prio property in bond ports 2023-05-15 16:02:01 +02:00
libnm-client-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-client-impl tests: adjust test-gir.py to allow extra elements in section name 2023-05-15 16:03:42 +02:00
libnm-client-public libnm: actually export a lot of routines that were supposed to be public 2022-11-11 16:49:39 +01:00
libnm-client-test build/meson: add dependency libnm_client_public_dep for "libnm-client-test" 2022-05-04 08:56:58 +02:00
libnm-core-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-aux-intern mptcp: rework "connection.mptcp-flags" for enabling MPTCP 2022-08-25 23:12:53 +02:00
libnm-core-impl ifcfg: better handle non-full-membership PKEY_ID with new PKEY_ID_NM variable 2023-06-05 11:05:16 +02:00
libnm-core-intern libnm: add nm_setting_infiniband_create_virtual_interface_name() helper 2023-05-25 22:47:24 +02:00
libnm-core-public bonding: add support to prio property in bond ports 2023-05-15 16:02:01 +02:00
libnm-crypto crypto: support EC private keys 2022-08-04 09:46:06 +02:00
libnm-glib-aux platform: add netlink support for bond port options 2023-05-15 15:44:18 +02:00
libnm-log-core glib-aux: drop nm_str_buf_init() for NM_STR_BUF_INIT() 2022-05-09 19:18:30 +02:00
libnm-log-null all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
libnm-platform platform: add support to prio property in bond ports 2023-05-15 15:44:39 +02:00
libnm-std-aux std-aux: fix NM_LIKELY()/NM_UNLIKELY() macros 2022-11-04 09:19:08 +01:00
libnm-systemd-core systemd: merge branch systemd into main 2022-08-11 21:51:58 +02:00
libnm-systemd-shared systemd: merge branch systemd into main 2022-08-11 21:51:58 +02:00
libnm-udev-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-base core: fix setting non-blocking FD in nm_utils_spawn_helper() 2023-04-06 12:26:33 +02:00
libnmc-setting ifcfg: better handle non-full-membership PKEY_ID with new PKEY_ID_NM variable 2023-06-05 11:05:16 +02:00
libnmt-newt format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
linux-headers linux-headers: include "mptcp.h" kernel header 2022-07-20 10:23:04 +02:00
n-acd modules: patch meson subprojects to use local dependencies 2022-07-25 10:27:33 +02:00
n-dhcp4 n-dhcp4: re-import git-subtree for 'src/n-dhcp4' 2022-08-11 14:47:04 +02:00
nm-cloud-setup cloud-setup: fix _aliyun_base() initializing base URL 2023-06-08 10:46:18 +02:00
nm-daemon-helper nm-daemon-helper: log to stderr any error from getaddrinfo() 2023-02-22 15:01:53 +01:00
nm-dispatcher all: reformat with clang-format (clang-tools-extra-14.0.0-1.fc36) and update gitlab-ci to f36 2022-07-06 11:06:53 +02:00
nm-initrd-generator tests: add tests for generating stable UUIDs for keyfile/initrd 2022-11-03 21:05:36 +01:00
nm-online all: reformat with clang-format (clang-tools-extra-14.0.0-1.fc36) and update gitlab-ci to f36 2022-07-06 11:06:53 +02:00
nm-priv-helper all: drop redundant includes 2022-05-09 19:20:18 +02:00
nmcli ifcfg: better handle non-full-membership PKEY_ID with new PKEY_ID_NM variable 2023-06-05 11:05:16 +02:00
nmtui nmtui: fix memory leak 2022-12-23 09:47:43 +01:00
tests tests: fix "test-client.py" for early python3 versions 2022-08-26 00:01:12 +02:00
meson.build Squashed 'src/c-stdaux/' changes from 99fe83cd5698..1407a1fb2754 2022-07-06 10:15:51 +02:00
README.md nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00

README.md

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library