Thomas Haller 52dbab7d07 all: use nm_clear_pointer() instead of g_clear_pointer() ... g_clear_pointer() would always cast the destroy notify function pointer to GDestroyNotify. That means, it lost some type safety, like GPtrArray *ptr_arr = ... g_clear_pointer (&ptr_arr, g_array_unref); Since glib 2.58 ([1]), g_clear_pointer() is also more type safe. But this is not used by NetworkManager, because we don't set GLIB_VERSION_MIN_REQUIRED to 2.58. [1] f9a9902aac We have nm_clear_pointer() to avoid this issue for a long time (pre 1.12.0). Possibly we should redefine in our source tree g_clear_pointer() as nm_clear_pointer(). However, I don't like to patch glib functions with our own variant. Arguably, we do patch g_clear_error() in such a manner. But there the point is to make the function inlinable. Also, nm_clear_pointer() returns a boolean that indicates whether anything was cleared. That is sometimes useful. I think we should just consistently use nm_clear_pointer() instead, which does always the preferable thing. Replace: sed 's/\<g_clear_pointer *(\([^;]*\), *\([a-z_A-Z0-9]\+\) *)/nm_clear_pointer (\1, \2)/g' $(git grep -l g_clear_pointer) -i		2020-03-23 11:22:38 +01:00
..
linux	all: unify format of our Copyright source code comments	2019-10-02 17:03:52 +02:00
tests	all: use nm_clear_pointer() instead of g_clear_pointer()	2020-03-23 11:22:38 +01:00
wifi	all: use nm_clear_g_free() instead of g_clear_pointer()	2020-03-23 11:05:34 +01:00
wpan	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nm-fake-platform.c	all: use nm_clear_pointer() instead of g_clear_pointer()	2020-03-23 11:22:38 +01:00
nm-fake-platform.h	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nm-linux-platform.c	all: use nm_clear_pointer() instead of g_clear_pointer()	2020-03-23 11:22:38 +01:00
nm-linux-platform.h	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nm-netlink.c	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nm-netlink.h	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nm-platform-private.h	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nm-platform-utils.c	all: use nm_utils_ifname_valid_kernel() instead of nm_utils_is_valid_iface_name()	2020-02-17 15:27:35 +01:00
nm-platform-utils.h	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nm-platform.c	all: use nm_clear_pointer() instead of g_clear_pointer()	2020-03-23 11:22:38 +01:00
nm-platform.h	platform: use C99 static array index in parameter of nm_platform_if_indextoname()	2020-02-10 19:11:50 +01:00
nmp-netns.c	shared: drop _STATIC variant of macros that define functions	2020-02-13 17:17:07 +01:00
nmp-netns.h	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nmp-object.c	all: use nm_clear_g_free() instead of g_clear_pointer()	2020-03-23 11:05:34 +01:00
nmp-object.h	platform: avoid compiler warning in _NMP_OBJECT_TYPE_IS_OBJ_WITH_IFINDEX()	2020-02-22 12:09:56 +01:00
nmp-rules-manager.c	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00
nmp-rules-manager.h	all: manually drop code comments with file description	2019-10-01 07:50:52 +02:00