NetworkManager/libnm-core/tests
Thomas Haller 85566e46d9 libnm-core: fix crash in update-secrets when trying to clear all settings without providing a connection variant
When the caller wants to clear all settings (thus providing
@setting_name NULL), a NM_VARIANT_TYPE_CONNECTION variant is
expected. This would lead to a crash when constructing the
@error literal due to uninitialized @key.

Clang also warns:

    Making all in .
    make[4]: Entering directory `./NetworkManager/libnm-core'
      CC       nm-connection.lo
    ../libnm-core/nm-connection.c:1016:25: error: variable 'key' is uninitialized when used here [-Werror,-Wuninitialized]
                                                 key);
                                                 ^~~
    ../libnm-core/nm-connection.c:962:17: note: initialize the variable 'key' to silence this warning
            const char *key;
                           ^
                            = NULL
    1 error generated.

Fixes: acf86f68b3
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-09-22 16:16:41 +02:00
..
Makefile.am libnm-core: update tests to be fully variant-based 2014-09-18 11:51:09 -04:00
test-compare.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
test-crypto.c libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
test-general.c libnm-core: update tests to be fully variant-based 2014-09-18 11:51:09 -04:00
test-secrets.c libnm-core: fix crash in update-secrets when trying to clear all settings without providing a connection variant 2014-09-22 16:16:41 +02:00
test-setting-8021x.c libnm-core: change DBUS_TYPE_G_UCHAR_ARRAY properties to G_TYPE_BYTES 2014-09-04 09:20:11 -04:00
test-setting-dcb.c libnm: add libnm/libnm-core (part 2) 2014-08-01 14:34:04 -04:00
test-settings-defaults.c libnm: add libnm/libnm-core (part 2) 2014-08-01 14:34:04 -04:00