James McCoy dbd365c3f9 nm-online: return from quit_if_connected after setting retval ... c5f17a97ea changed nm-online to determine the status asynchronously, however this introduced a regression with "nm-online -x -q" when there is connectivity. if ( state == NM_STATE_CONNECTED_LOCAL || state == NM_STATE_CONNECTED_SITE || state == NM_STATE_CONNECTED_GLOBAL) { data->retval = 0; g_main_loop_quit (data->loop); } } if (data->exit_no_nm && (state != NM_STATE_CONNECTING)) { data->retval = 1; g_main_loop_quit (data->loop); } After setting data->retval = 0 in the "state is connected" branch, the function falls through to the "exit_no_nm and !connecting" branch, overwriting data->retval. This causes "nm-online -x -q" to incorrectly report an offline state. Adding an explicit "return;" after any state where data->retval is set ensures that the value isn't overwritten before main() uses it. Fixes: c5f17a97ea https://mail.gnome.org/archives/networkmanager-list/2017-January/msg00058.html		2017-01-28 10:54:04 +01:00
..
cli	cli: avoid use-after free on connection deletion	2017-01-27 13:33:28 +01:00
common	cli: macsec support	2017-01-16 17:47:10 +01:00
tui	all: use nm_utils_is_valid_iface_name()	2017-01-06 15:11:56 +01:00
nm-online.c	nm-online: return from quit_if_connected after setting retval	2017-01-28 10:54:04 +01:00