fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-24 20:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src
History
Íñigo Huguet bdbcda1e22 vpn: handle hint tags in the daemon 
Commit 345bd1b187 ('libnmc: fix secrets request on 2nd stage of 2FA
authentication') and commit 27c701ebfb ('libnmc: allow user input in
ECHO mode for 2FA challenges') introduced 2 new tags that hints for the
secret agents can have as prefix.

These tags were processed (and removed) in the secret agents, not in the
daemon. This is wrong because a system with an updated VPN plugin but a
not yet updated secret agent (like nm-plasma) will fail: it won't remove
the prefix and the daemon will save the secret with the prefix, i.e.
"x-dynamic-challenge:challenge-response" instead of just
"challenge-response". Then, VPN plugins doesn't recognize it, failing the
profile's activation. This is, in fact, an API break.

Also, if the VPN connection already existed before updating NM and the
VPN plugin, the secret flags are not added to the profile (they are only
added when the profile is created or modified). This causes the user's
first time response is saved to the profile, so the activation fails the
second and next times.

See:
- https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1536
- https://gitlab.gnome.org/GNOME/NetworkManager-openvpn/-/issues/142

Anyway, in a good design the daemon should contain almost all the logic
and the clients should keep as simple as possible. Fix above's problems
by letting the daemon to receive the secret names with the prefix
already included. The daemon will strip it and will know what it means.

Note that this is done only in the functions that saves the secrets from
the data received via D-Bus. For example, nm_setting_vpn_add_secret
doesn't need to do it because this value shouldn't come from VPN
plugin's hints.

(cherry picked from commit 0583e1f843)
(cherry picked from commit 574741783c)
2024-06-18 16:06:13 +02:00
..
c-list c-list: re-import git-subtree for 'src/c-list' 2022-07-19 09:02:36 +02:00
c-rbtree c-rbtree: re-import git-subtree for 'src/c-rbtree' 2022-11-23 18:00:31 +01:00
c-siphash c-siphash: re-import git-subtree for 'src/c-siphash' 2022-11-23 18:00:33 +01:00
c-stdaux c-stdaux: re-import git-subtree for 'src/c-stdaux' 2023-03-03 13:40:38 +01:00
contrib all: use nm_strv_empty_new() helper 2023-11-30 15:53:21 +01:00
core vpn: allow IP configurations with routes and without addresses 2024-06-17 15:37:08 +02:00
libnm-base sriov: allow reading empty eswitch paramaters via Devlink 2024-02-21 11:27:36 +01:00
libnm-client-aux-extern all: use nm_random_*() instead of g_random_*() 2023-01-30 10:51:13 +01:00
libnm-client-impl libnm: add generic.device-handler property 2024-02-21 11:49:11 +01:00
libnm-client-public HSR: add support to HSR/PRP interface 2023-12-05 08:05:56 +01:00
libnm-client-test all: use G_SPAWN_CLOEXEC_PIPES with g_spawn_async_with_pipes() 2023-04-04 08:43:20 +02:00
libnm-core-aux-extern dispatcher: support device-handler actions 2024-02-21 11:49:16 +01:00
libnm-core-aux-intern libnm,nmcli: add ipvx.dhcp-dscp property 2024-02-06 17:02:30 +01:00
libnm-core-impl vpn: handle hint tags in the daemon 2024-06-18 16:06:13 +02:00
libnm-core-intern nm-setting: implement direct_enum as GObject property of type int 2024-02-21 11:20:52 +01:00
libnm-core-public checkpoint: Allow rollback on internal global DNS 2024-03-20 19:35:42 +01:00
libnm-crypto doc: replace all (allow-none) annotations by (optional) and/or (nullable) 2023-03-27 11:49:43 +02:00
libnm-glib-aux libnm-glib-aux: fix comments about UUID generation 2024-05-15 12:11:42 +02:00
libnm-lldp core: workaround "-Wnonnull-compare" warning in nm_lldp_neighbor_tlv_get_oui() 2024-06-01 17:18:58 +02:00
libnm-log-core log,dhcp: avoid deprecated GTimeVal API and use g_get_real_time() 2023-03-21 10:21:28 +01:00
libnm-log-null all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
libnm-platform platform: avoid routes resync for routes that we don't track 2024-05-13 13:33:06 +02:00
libnm-std-aux std-aux: workaround usage of _Pragma() inside nm_assert() 2024-02-09 12:53:54 +01:00
libnm-systemd-core build: use "-Wno-nonnull-compare" for building systemd 2024-02-26 12:09:09 +01:00
libnm-systemd-shared build: use "-Wno-nonnull-compare" for building systemd 2024-02-26 12:09:09 +01:00
libnm-udev-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-base device: support creating generic devices via device-handler 2024-02-21 11:49:19 +01:00
libnmc-setting man: fix missing deprecation message 2024-04-18 15:31:54 +02:00
libnmt-newt nmtui: fix deletion confirmation with ESC key press 2024-01-18 10:16:45 +01:00
linux-headers platform: remove CSME related code 2023-09-25 11:46:24 +00:00
n-acd n-acd: use separate seed state for each probe of the same acd 2023-10-05 09:02:57 +02:00
n-dhcp4 n-dhcp4: change the default DSCP value to 0 2024-02-06 17:02:31 +01:00
nm-cloud-setup cloud-setup: more sandboxing in service file 2024-01-16 08:59:07 +01:00
nm-compat-headers all: add src/nm-compat-headers for patching included system headers 2022-09-23 11:43:33 +02:00
nm-daemon-helper daemon-helper: use _nm_strerror_r() to avoid non-thread-safe strerror() 2023-09-12 12:39:43 +00:00
nm-dispatcher nm-dispatcher: fix crash when parsing output dictionary 2024-03-26 10:53:43 +01:00
nm-initrd-generator initrd: add support for rd.net.dhcp.dscp property 2024-02-06 17:02:31 +01:00
nm-online all: use NM_MAX() instead of MAX() 2023-11-15 09:32:21 +01:00
nm-priv-helper all: drop redundant includes 2022-05-09 19:20:18 +02:00
nmcli man: fix missing deprecation message 2024-04-18 15:31:54 +02:00
nmtui nmtui: Add bond for creating bridge port interface 2024-02-21 11:48:21 +01:00
tests libnm,nmcli: add ipvx.dhcp-dscp property 2024-02-06 17:02:30 +01:00
meson.build build: workaround -Wno-calloc-transposed-args warning in systemd code 2024-02-26 12:17:07 +01:00
README.md nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00

README.md

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library